You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hc.apache.org by pavolloffay <gi...@git.apache.org> on 2017/05/09 13:01:02 UTC
[GitHub] httpclient pull request #76: Allow to add exec interceptor as the first and ...
GitHub user pavolloffay opened a pull request:
https://github.com/apache/httpclient/pull/76
Allow to add exec interceptor as the first and the last
Related to OpenTracing integration and https://issues.apache.org/jira/browse/HTTPCLIENT-1842?focusedCommentId=15996807&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15996807
cc @ok2c
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/pavolloffay/httpclient add-interceptor-fisrt-last
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/httpclient/pull/76.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #76
----
commit 91ebbac98e3b68eec20e8627af93804406103100
Author: Pavol Loffay <pl...@redhat.com>
Date: 2017-05-09T12:58:58Z
Allow to add exec interceptor as the first and the last
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] httpclient issue #76: Allow to add exec interceptor as the first and the las...
Posted by pavolloffay <gi...@git.apache.org>.
Github user pavolloffay commented on the issue:
https://github.com/apache/httpclient/pull/76
When is going the release of 5.0 happen?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] httpclient issue #76: Allow to add exec interceptor as the first and the las...
Posted by garydgregory <gi...@git.apache.org>.
Github user garydgregory commented on the issue:
https://github.com/apache/httpclient/pull/76
I do not see any either . You can be the first ;-)
HttpCore 5 GA has to come first. Oleg can speak to schedule. I think it will be a while though. We are in alpha mode.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] httpclient issue #76: Allow to add exec interceptor as the first and the las...
Posted by ok2c <gi...@git.apache.org>.
Github user ok2c commented on the issue:
https://github.com/apache/httpclient/pull/76
@pavolloffay Please bear with me a few more days. I'll merge your changes as soon as we are done migrating to Git
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] httpclient issue #76: Allow to add exec interceptor as the first and the las...
Posted by pavolloffay <gi...@git.apache.org>.
Github user pavolloffay commented on the issue:
https://github.com/apache/httpclient/pull/76
Last/first interceptor added to the `AsyncClient`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] httpclient issue #76: Allow to add exec interceptor as the first and the las...
Posted by ok2c <gi...@git.apache.org>.
Github user ok2c commented on the issue:
https://github.com/apache/httpclient/pull/76
HttpClient 5.0-alpha2 vote is ongoing.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] httpclient issue #76: Allow to add exec interceptor as the first and the las...
Posted by pavolloffay <gi...@git.apache.org>.
Github user pavolloffay commented on the issue:
https://github.com/apache/httpclient/pull/76
Could it go in without tests? I don't know how the test should look like.
To implement tests I need to access `NamedElementChain<ExecChainHandler>` which is constructed inside `HttpClientBuilder.build()`. I could define a new property with a package visibility getter in the builder, but it's not so nice.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] httpclient issue #76: Allow to add exec interceptor as the first and the las...
Posted by ok2c <gi...@git.apache.org>.
Github user ok2c commented on the issue:
https://github.com/apache/httpclient/pull/76
Looks good to me. Could you please do the same for the async client builder?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] httpclient issue #76: Allow to add exec interceptor as the first and the las...
Posted by pavolloffay <gi...@git.apache.org>.
Github user pavolloffay commented on the issue:
https://github.com/apache/httpclient/pull/76
> That seems quite reasonable. Some unit tests would be nice as well.
@garydgregory Could you please point me to existing tests for `HttpClientBuilder#addExecInterceptorBefore` and its alternatives? I wasn't able to find them.
> HttpClient 5.0-alpha2 vote is ongoing.
When is the GA planned for? I have to look at async client, what is necessary for tracing.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org