You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2022/08/15 20:48:42 UTC
[GitHub] [iceberg] jackye1995 commented on a diff in pull request #5541: Build: Resolve unchecked Map type cast in TestAvroNameMapping
jackye1995 commented on code in PR #5541:
URL: https://github.com/apache/iceberg/pull/5541#discussion_r946112533
##########
core/src/test/java/org/apache/iceberg/avro/TestAvroNameMapping.java:
##########
@@ -102,6 +102,7 @@ public void testMapProjections() throws IOException {
Types.NestedField.required(1, "lat", Types.FloatType.get()))))));
projected = writeAndRead(writeSchema, readSchema, record, nameMapping);
+ @SuppressWarnings("unchecked")
Review Comment:
I think we can directly place @SuppressWarnings on top of the method, so we only need 1
##########
core/src/test/java/org/apache/iceberg/avro/TestAvroNameMapping.java:
##########
@@ -102,6 +102,7 @@ public void testMapProjections() throws IOException {
Types.NestedField.required(1, "lat", Types.FloatType.get()))))));
projected = writeAndRead(writeSchema, readSchema, record, nameMapping);
+ @SuppressWarnings("unchecked")
Review Comment:
I think we can directly place `@SuppressWarnings` on top of the method, so we only need 1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org