You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@jmeter.apache.org by pm...@apache.org on 2016/02/18 00:05:21 UTC

svn commit: r1730971 - /jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/sampler/HTTPSamplerBase.java

Author: pmouawad
Date: Wed Feb 17 23:05:21 2016
New Revision: 1730971

URL: http://svn.apache.org/viewvc?rev=1730971&view=rev
Log:
Bug 59023 - HttpSampler UI : rework the embedded resources labels and change default number of parallel downloads to 6
Fix effectively the issue (thanks sebb for the note)
Bugzilla Id: 59023

Modified:
    jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/sampler/HTTPSamplerBase.java

Modified: jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/sampler/HTTPSamplerBase.java
URL: http://svn.apache.org/viewvc/jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/sampler/HTTPSamplerBase.java?rev=1730971&r1=1730970&r2=1730971&view=diff
==============================================================================
--- jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/sampler/HTTPSamplerBase.java (original)
+++ jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/sampler/HTTPSamplerBase.java Wed Feb 17 23:05:21 2016
@@ -180,7 +180,9 @@ public abstract class HTTPSamplerBase ex
     
     public static final String CONCURRENT_POOL = "HTTPSampler.concurrentPool"; // $NON-NLS-1$
 
-    private static final String CONCURRENT_POOL_DEFAULT = "6"; // default for concurrent pool (do not change)
+    public static final int CONCURRENT_POOL_SIZE = 6; // Default concurrent pool size for download embedded resources
+
+    private static final String CONCURRENT_POOL_DEFAULT = Integer.toString(CONCURRENT_POOL_SIZE); // default for concurrent pool
     
     private static final String USER_AGENT = "User-Agent"; // $NON-NLS-1$
 
@@ -196,8 +198,6 @@ public abstract class HTTPSamplerBase ex
     private static final boolean IGNORE_FAILED_EMBEDDED_RESOURCES = 
             JMeterUtils.getPropDefault("httpsampler.ignore_failed_embedded_resources", false); // $NON-NLS-1$ // default value: false
 
-    public static final int CONCURRENT_POOL_SIZE = 4; // Default concurrent pool size for download embedded resources
-
     private static final boolean IGNORE_EMBEDDED_RESOURCES_DATA = 
             JMeterUtils.getPropDefault("httpsampler.embedded_resources_use_md5", false); // $NON-NLS-1$ // default value: false

Re: svn commit: r1730971 - /jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/sampler/HTTPSamplerBase.java

Posted by sebb <se...@gmail.com>.
So that was the reason for the "no change" comment. Well spotted.

On 17 February 2016 at 23:05,  <pm...@apache.org> wrote:
> Author: pmouawad
> Date: Wed Feb 17 23:05:21 2016
> New Revision: 1730971
>
> URL: http://svn.apache.org/viewvc?rev=1730971&view=rev
> Log:
> Bug 59023 - HttpSampler UI : rework the embedded resources labels and change default number of parallel downloads to 6
> Fix effectively the issue (thanks sebb for the note)
> Bugzilla Id: 59023
>
> Modified:
>     jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/sampler/HTTPSamplerBase.java
>
> Modified: jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/sampler/HTTPSamplerBase.java
> URL: http://svn.apache.org/viewvc/jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/sampler/HTTPSamplerBase.java?rev=1730971&r1=1730970&r2=1730971&view=diff
> ==============================================================================
> --- jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/sampler/HTTPSamplerBase.java (original)
> +++ jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/sampler/HTTPSamplerBase.java Wed Feb 17 23:05:21 2016
> @@ -180,7 +180,9 @@ public abstract class HTTPSamplerBase ex
>
>      public static final String CONCURRENT_POOL = "HTTPSampler.concurrentPool"; // $NON-NLS-1$
>
> -    private static final String CONCURRENT_POOL_DEFAULT = "6"; // default for concurrent pool (do not change)
> +    public static final int CONCURRENT_POOL_SIZE = 6; // Default concurrent pool size for download embedded resources
> +
> +    private static final String CONCURRENT_POOL_DEFAULT = Integer.toString(CONCURRENT_POOL_SIZE); // default for concurrent pool
>
>      private static final String USER_AGENT = "User-Agent"; // $NON-NLS-1$
>
> @@ -196,8 +198,6 @@ public abstract class HTTPSamplerBase ex
>      private static final boolean IGNORE_FAILED_EMBEDDED_RESOURCES =
>              JMeterUtils.getPropDefault("httpsampler.ignore_failed_embedded_resources", false); // $NON-NLS-1$ // default value: false
>
> -    public static final int CONCURRENT_POOL_SIZE = 4; // Default concurrent pool size for download embedded resources
> -
>      private static final boolean IGNORE_EMBEDDED_RESOURCES_DATA =
>              JMeterUtils.getPropDefault("httpsampler.embedded_resources_use_md5", false); // $NON-NLS-1$ // default value: false
>
>
>