[jira] [Commented] (HBASE-5045) Add the table name and cf name for the next call int the task monitor

["Phabricator (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-5045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13268691#comment-13268691 ] 

Phabricator commented on HBASE-5045:
------------------------------------

amirshim has commented on the revision "[jira] [HBASE-5045] Annotation for Custom Param formatting and next() RPC call info".

INLINE COMMENTS
  src/main/java/org/apache/hadoop/hbase/ipc/WritableRpcEngine.java:319 status.setRPC a couple of lines away now takes method as a param.
  src/main/java/org/apache/hadoop/hbase/monitoring/MonitoredRPCHandler.java:45 The "real" method returned by the Java reflection API... see MonitoredRPCHandlerImpl for more info.
  src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java:3489 This object is stored across RPC calls and we store the original scan, so that we can easily print the information about the scan in the task monitor. It needs to be accessible from ScanParamsFormatter
  src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java:2210 It doesn't have to be in here, but if not, then we have to expose some internals of HRS. This class needs to understand the internals, since it provides introspection about what it's method(s) do. i.e. If we change how we do scanner lookups, this class needs to change too.
  src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java:2221 It's supposed to be strongly bound since it provides introspection about it's methods.
  src/main/java/org/apache/hadoop/hbase/util/ParamFormat.java:27 It's possible, but should be done in another diff.
  src/main/java/org/apache/hadoop/hbase/util/ParamFormatHelper.java:63 It's introspection on a method we control, since we force it to derive from ParamFormatter<>.  I called it getMap() to be consistent with the getMap() used in the TaskMonitor.
  src/main/java/org/apache/hadoop/hbase/util/ParamFormatHelper.java:102 See above.  I called it getMap to be consistent with the TaskMonitor functions.
  src/main/java/org/apache/hadoop/hbase/util/ParamFormatter.java:24 It formats information about a method call given the params it takes. PrettyPrint makes me think that it actually outputs the info somewhere, as opposed to a formatter that arranges the data for later pretty printing.  I shouldn't have put pretty print in so many comments.

REVISION DETAIL
  https://reviews.facebook.net/D2913

BRANCH
  add_the_table_name_and_cf_name_for_the_next_HBASE-5045_v3

                
> Add the table name and cf name for the next call int the task monitor
> ---------------------------------------------------------------------
>
>                 Key: HBASE-5045
>                 URL: https://issues.apache.org/jira/browse/HBASE-5045
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Liyin Tang
>            Assignee: Amir Shimoni
>         Attachments: D2913.1.patch, D2913.2.patch
>
>
> In the task monitor, we don't have much information about the next call compared to other operations.
> It would be nice to add the table name and cf name for each next call in the task monitor.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira