You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/10/06 14:55:57 UTC
[GitHub] [flink] StephanEwen opened a new pull request #13548: [FLINK-19441][network] Avoid loading of ResultPartition wrapper class for consumable notifications when possible.
StephanEwen opened a new pull request #13548:
URL: https://github.com/apache/flink/pull/13548
## What is the purpose of the change
A small code optimization attempting to reduce the virtual method call overhead on the per-record methods in `ResultPartition`.
It does that by making the class wrapping the `ResultPartition` (formerly `ConsumableNotifyingResultPartitionWriterDecorator`) a different class than the one with the factory method. That way, if the factory method never needs a wrapper class (under normal configuration, it never needs one) the wrapping class is never loaded, and the JIT can find out (through CHA) that only one implementation for the per-record methods on `ResultPartition` exists.
## Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): **no**
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: **no**
- The serializers: **no**
- The runtime per-record code paths (performance sensitive): **yes**
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: **no**
- The S3 file system connector: **no**
## Documentation
- Does this pull request introduce a new feature? **no**
- If yes, how is the feature documented? **not applicable**
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] asfgit merged pull request #13548: [FLINK-19441][network] Avoid loading of ResultPartition wrapper class for consumable notifications when possible.
Posted by GitBox <gi...@apache.org>.
asfgit merged pull request #13548:
URL: https://github.com/apache/flink/pull/13548
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #13548: [FLINK-19441][network] Avoid loading of ResultPartition wrapper class for consumable notifications when possible.
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #13548:
URL: https://github.com/apache/flink/pull/13548#issuecomment-704335711
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "3e996d9860a1b1f5431a2c3abee8f1c41b7bbd00",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "3e996d9860a1b1f5431a2c3abee8f1c41b7bbd00",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 3e996d9860a1b1f5431a2c3abee8f1c41b7bbd00 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] StephanEwen commented on pull request #13548: [FLINK-19441][network] Avoid loading of ResultPartition wrapper class for consumable notifications when possible.
Posted by GitBox <gi...@apache.org>.
StephanEwen commented on pull request #13548:
URL: https://github.com/apache/flink/pull/13548#issuecomment-704351300
Adjusted the code to make the role of the utility class more clear.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #13548: [FLINK-19441][network] Avoid loading of ResultPartition wrapper class for consumable notifications when possible.
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #13548:
URL: https://github.com/apache/flink/pull/13548#issuecomment-704328667
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 3e996d9860a1b1f5431a2c3abee8f1c41b7bbd00 (Tue Oct 06 14:58:11 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13548: [FLINK-19441][network] Avoid loading of ResultPartition wrapper class for consumable notifications when possible.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13548:
URL: https://github.com/apache/flink/pull/13548#issuecomment-704335711
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "3e996d9860a1b1f5431a2c3abee8f1c41b7bbd00",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7243",
"triggerID" : "3e996d9860a1b1f5431a2c3abee8f1c41b7bbd00",
"triggerType" : "PUSH"
}, {
"hash" : "d848698ca39ad0d2e6cca340ff183b5aeb00fdf9",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "d848698ca39ad0d2e6cca340ff183b5aeb00fdf9",
"triggerType" : "PUSH"
}, {
"hash" : "16fb79efc9e2e70e0ee3f99d109d11b812f308f7",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "16fb79efc9e2e70e0ee3f99d109d11b812f308f7",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 3e996d9860a1b1f5431a2c3abee8f1c41b7bbd00 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7243)
* d848698ca39ad0d2e6cca340ff183b5aeb00fdf9 UNKNOWN
* 16fb79efc9e2e70e0ee3f99d109d11b812f308f7 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13548: [FLINK-19441][network] Avoid loading of ResultPartition wrapper class for consumable notifications when possible.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13548:
URL: https://github.com/apache/flink/pull/13548#issuecomment-704335711
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "3e996d9860a1b1f5431a2c3abee8f1c41b7bbd00",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7243",
"triggerID" : "3e996d9860a1b1f5431a2c3abee8f1c41b7bbd00",
"triggerType" : "PUSH"
}, {
"hash" : "d848698ca39ad0d2e6cca340ff183b5aeb00fdf9",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "d848698ca39ad0d2e6cca340ff183b5aeb00fdf9",
"triggerType" : "PUSH"
}, {
"hash" : "16fb79efc9e2e70e0ee3f99d109d11b812f308f7",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7249",
"triggerID" : "16fb79efc9e2e70e0ee3f99d109d11b812f308f7",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 3e996d9860a1b1f5431a2c3abee8f1c41b7bbd00 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7243)
* d848698ca39ad0d2e6cca340ff183b5aeb00fdf9 UNKNOWN
* 16fb79efc9e2e70e0ee3f99d109d11b812f308f7 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7249)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13548: [FLINK-19441][network] Avoid loading of ResultPartition wrapper class for consumable notifications when possible.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13548:
URL: https://github.com/apache/flink/pull/13548#issuecomment-704335711
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "3e996d9860a1b1f5431a2c3abee8f1c41b7bbd00",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7243",
"triggerID" : "3e996d9860a1b1f5431a2c3abee8f1c41b7bbd00",
"triggerType" : "PUSH"
}, {
"hash" : "d848698ca39ad0d2e6cca340ff183b5aeb00fdf9",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "d848698ca39ad0d2e6cca340ff183b5aeb00fdf9",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 3e996d9860a1b1f5431a2c3abee8f1c41b7bbd00 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7243)
* d848698ca39ad0d2e6cca340ff183b5aeb00fdf9 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org