You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@devlake.apache.org by "abeizn (via GitHub)" <gi...@apache.org> on 2023/09/25 09:33:15 UTC
[GitHub] [incubator-devlake] abeizn opened a new pull request, #6145: fix: db_url add tls=skip-verify
abeizn opened a new pull request, #6145:
URL: https://github.com/apache/incubator-devlake/pull/6145
### Summary
db_url add tls=skip-verify
### Does this close any open issues?
Related to #5659
### Screenshots
previous:
now:
### Other Information
Any other information that is important to this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] klesh commented on a diff in pull request #6145: fix: db_url add tls=skip-verify and add tls connection
Posted by "klesh (via GitHub)" <gi...@apache.org>.
klesh commented on code in PR #6145:
URL: https://github.com/apache/incubator-devlake/pull/6145#discussion_r1336810286
##########
backend/core/runner/db.go:
##########
@@ -109,6 +114,9 @@ func addLocal(query url.Values) string {
if query.Get("loc") == "" {
query.Set("loc", "Local")
}
+ if query.Get("ca-cert") != "" {
Review Comment:
The function name should be updated to reflect what it does.
for example `sanitizeQuery`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] klesh merged pull request #6145: fix: db_url add tls=skip-verify and add tls connection
Posted by "klesh (via GitHub)" <gi...@apache.org>.
klesh merged PR #6145:
URL: https://github.com/apache/incubator-devlake/pull/6145
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] abeizn commented on pull request #6145: fix: db_url add tls=skip-verify and add tls connection
Posted by "abeizn (via GitHub)" <gi...@apache.org>.
abeizn commented on PR #6145:
URL: https://github.com/apache/incubator-devlake/pull/6145#issuecomment-1735075470
doc link: https://github.com/apache/incubator-devlake-website/pull/648
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org