You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/05/04 01:45:04 UTC
[GitHub] [pulsar] liangyepianzhou opened a new pull request, #15418: [Fix][Txn]Fix transaction component recover fillQueue
liangyepianzhou opened a new pull request, #15418:
URL: https://github.com/apache/pulsar/pull/15418
### Motivation & Modification
The queue size + NUMBER_OF_PER_READ_ENTRY should <= the capacity of queue instead of the queue size <= the capacity of queue.
### About test
It hard to add test for this change.
This class of replay/recover/FillEntryQueueCallback is not public, so it can not be import by test.
And then their flied can not be changed by reflection.
With `Thread.sleep` allowed, we can only test the recover of TC by call a `Thread.sleep` in `transactionLogReplayCallback` and can not test TP/TB.
### Verifying this change
- [ ] Make sure that the change passes the CI checks.
*(Please pick either of the following options)*
This change is a trivial rework / code cleanup without any test coverage.
*(or)*
This change is already covered by existing tests, such as *(please describe tests)*.
*(or)*
This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end deployment with large payloads (10MB)*
- *Extended integration test for recovery after broker failure*
### Does this pull request potentially affect one of the following parts:
*If `yes` was chosen, please highlight the changes*
- Dependencies (does it add or upgrade a dependency): (yes / no)
- The public API: (yes / no)
- The schema: (yes / no / don't know)
- The default values of configurations: (yes / no)
- The wire protocol: (yes / no)
- The rest endpoints: (yes / no)
- The admin cli options: (yes / no)
- Anything that affects deployment: (yes / no / don't know)
### Documentation
Check the box below or label this PR directly.
Need to update docs?
- [ ] `doc-required`
(Your PR needs to update docs and you will update later)
- [x] `no-need-doc`
(Please explain why)
- [ ] `doc`
(Your PR contains doc changes)
- [ ] `doc-added`
(Docs have been already added)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] liangyepianzhou commented on pull request #15418: [Fix][Txn]Fix transaction component recover fillQueue
Posted by GitBox <gi...@apache.org>.
liangyepianzhou commented on PR #15418:
URL: https://github.com/apache/pulsar/pull/15418#issuecomment-1119195289
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] congbobo184 commented on pull request #15418: [Fix][Txn]Fix transaction component recover fillQueue
Posted by GitBox <gi...@apache.org>.
congbobo184 commented on PR #15418:
URL: https://github.com/apache/pulsar/pull/15418#issuecomment-1118073786
@mattisonchao yes, after testing it solved the problem
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] mattisonchao commented on pull request #15418: [Fix][Txn]Fix transaction component recover fillQueue
Posted by GitBox <gi...@apache.org>.
mattisonchao commented on PR #15418:
URL: https://github.com/apache/pulsar/pull/15418#issuecomment-1118068114
Question:
Does this PR solve the problem of skipping entries?
/cc @congbobo184
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] congbobo184 merged pull request #15418: [Fix][Txn]Fix transaction component recover fillQueue
Posted by GitBox <gi...@apache.org>.
congbobo184 merged PR #15418:
URL: https://github.com/apache/pulsar/pull/15418
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] mattisonchao commented on pull request #15418: [Fix][Txn]Fix transaction component recover fillQueue
Posted by GitBox <gi...@apache.org>.
mattisonchao commented on PR #15418:
URL: https://github.com/apache/pulsar/pull/15418#issuecomment-1118067545
Feels like more context is needed to help contributors review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org