You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/07/09 09:41:11 UTC
[GitHub] [skywalking] wu-sheng commented on a change in pull request #5064: Better Vert.x endpoint names
wu-sheng commented on a change in pull request #5064:
URL: https://github.com/apache/skywalking/pull/5064#discussion_r452092495
##########
File path: test/plugin/scenarios/vertx-web-3.54minus-scenario/config/expectedData.yaml
##########
@@ -97,10 +113,37 @@ segmentItems:
skipAnalysis: false
tags:
- {key: http.method, value: HEAD}
- - {key: url, value: /vertx-web-3_54minus-scenario/case/healthCheck}
+ - {key: url, value: '/vertx-web-3_54minus-scenario/case/healthCheck'}
+ - {key: status_code, value: '200'}
+ refs:
+ - {parentEndpoint: '{GET}/vertx-web-3_54minus-scenario/case/web-case', networkAddress: 'localhost:8080',
+ refType: CrossProcess, parentSpanId: 3, parentTraceSegmentId: not null,
+ parentServiceInstance: not null, parentService: vertx-web-3.54minus-scenario,
+ traceId: not null}
+ - segmentId: not null
+ spans:
+ - {operationName: org.apache.skywalking.apm.testcase.vertxweb.controller.VertxWebController$$Lambda$.handle(RoutingContext),
Review comment:
This span expected data seems in a different format.
##########
File path: test/plugin/scenarios/vertx-web-3.6plus-scenario/config/expectedData.yaml
##########
@@ -97,10 +113,37 @@ segmentItems:
skipAnalysis: false
tags:
- {key: http.method, value: HEAD}
- - {key: url, value: /vertx-web-3_6plus-scenario/case/healthCheck}
+ - {key: url, value: '/vertx-web-3_6plus-scenario/case/healthCheck'}
+ - {key: status_code, value: '200'}
+ refs:
+ - {parentEndpoint: '{GET}/vertx-web-3_6plus-scenario/case/web-case', networkAddress: 'localhost:8080',
+ refType: CrossProcess, parentSpanId: 3, parentTraceSegmentId: not null,
+ parentServiceInstance: not null, parentService: vertx-web-3.6plus-scenario,
+ traceId: not null}
+ - segmentId: not null
+ spans:
+ - {operationName: org.apache.skywalking.apm.testcase.vertxweb.controller.VertxWebController$$Lambda$.handle(RoutingContext),
Review comment:
Same format issue here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org