You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2022/08/24 09:23:50 UTC

[GitHub] [nifi-minifi-cpp] adamdebreceni opened a new pull request, #1404: MINIFICPP-1918 - Windows test fix

adamdebreceni opened a new pull request, #1404:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1404

   Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
   
   In order to streamline the review of the contribution we ask you
   to ensure the following steps have been taken:
   
   ### For all changes:
   - [ ] Is there a JIRA ticket associated with this PR? Is it referenced
        in the commit message?
   
   - [ ] Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
   
   - [ ] Has your PR been rebased against the latest commit within the target branch (typically main)?
   
   - [ ] Is your initial contribution a single, squashed commit?
   
   ### For code changes:
   - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
   - [ ] If applicable, have you updated the LICENSE file?
   - [ ] If applicable, have you updated the NOTICE file?
   
   ### For documentation related changes:
   - [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
   
   ### Note:
   Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nifi-minifi-cpp] lordgamez closed pull request #1404: MINIFICPP-1918 - Windows test fix

Posted by GitBox <gi...@apache.org>.
lordgamez closed pull request #1404: MINIFICPP-1918 - Windows test fix
URL: https://github.com/apache/nifi-minifi-cpp/pull/1404


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nifi-minifi-cpp] adam-markovics commented on pull request #1404: MINIFICPP-1918 - Windows test fix

Posted by GitBox <gi...@apache.org>.
adam-markovics commented on PR #1404:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1404#issuecomment-1225702010

   > Can you explain somewhere (commit message / Jira / PR description) why this caused a test failure?
   
   I'm also curious. My guess would be the static variables that are now defined in just one source file, instead of the many previously.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nifi-minifi-cpp] adamdebreceni commented on pull request #1404: MINIFICPP-1918 - Windows test fix

Posted by GitBox <gi...@apache.org>.
adamdebreceni commented on PR #1404:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1404#issuecomment-1225805084

   > Can you explain somewhere (commit message / Jira / PR description) why this caused a test failure?
   
   on windows if the static variables are defined in the headers each dll gets their separate instance, so when the scripting extension pushed the description of the python processor into the external bundle registry, it did so into its own separate instance, making it invisible while querying and building the agent manifest based on the (most probably) minifi-core's instance


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org