[GitHub] [solr] mpetris commented on pull request #1156: [SOLR-16515] Remove synchronized access to cachedOrdMaps in SlowCompositeReaderWrapper

[GitBox <gi...@apache.org>]

mpetris commented on PR #1156:
URL: https://github.com/apache/solr/pull/1156#issuecomment-1300514827

   > Hey, this looks excellent! The code looks a bit deja-vu... do you think we could & should factorize out anything common?
   
   @dsmiley We could factorize out most of `SlowCompositeReaderWrapper::getSortedDocValues` and `SlowCompositeReaderWrapper::getSortedSetDocValues` to `MultiDocValues` just like it was. But to me it looks like as the two `MultiDocValues` methods were used in `SlowCompositeReaderWrapper` only. So I'm not sure that it would be worth the effort. Moreover since the usage of `MultiDocValues` seems to be discouraged anyway.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org