You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@carbondata.apache.org by nehabhardwaj01 <gi...@git.apache.org> on 2017/08/29 12:23:12 UTC
[GitHub] carbondata pull request #1298: [CARBONDATA-1430] Resolved Split Partition Bu...
GitHub user nehabhardwaj01 opened a pull request:
https://github.com/apache/carbondata/pull/1298
[CARBONDATA-1430] Resolved Split Partition Bug When Extra Space was Present in the NewList
Split Partition Raises Exception if any extra space is given in the SplitList elements.
Jira : https://issues.apache.org/jira/projects/CARBONDATA/issues/CARBONDATA-1430?filter=allopenissues
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/nehabhardwaj01/incubator-carbondata resolve/CARBONDATA-1430
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/carbondata/pull/1298.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1298
----
commit 1a5102327fae05e986ac2aee539767e21b4a1379
Author: nehabhardwaj01 <bh...@gmail.com>
Date: 2017-08-14T07:26:15Z
CarbonHiveRecordReader Unit Tests
commit c90f8d2e67c1be3259750b08b4e488550573bb84
Author: nehabhardwaj01 <bh...@gmail.com>
Date: 2017-08-14T07:27:35Z
Merge remote-tracking branch 'upstream/master'
commit ac14371f73defbe206fd74a692671e830c11781e
Author: nehabhardwaj01 <bh...@gmail.com>
Date: 2017-08-28T07:56:34Z
Merge remote-tracking branch 'upstream/master'
commit cb619ab154ccc1321539a2ef261ba5a9cbaec529
Author: nehabhardwaj01 <bh...@gmail.com>
Date: 2017-08-29T10:55:02Z
Merge remote-tracking branch 'upstream/master'
commit 50c5be2e0c2c6564a358175045fa172c8cc8be93
Author: nehabhardwaj01 <bh...@gmail.com>
Date: 2017-08-29T12:13:45Z
Fixed CARBONDATA-1430
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] carbondata issue #1298: [CARBONDATA-1430] Resolved Split Partition Bug When ...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1298
SDV Build Success with Spark 2.1, Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/363/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] carbondata issue #1298: [CARBONDATA-1430] Resolved Split Partition Bug When ...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1298
SDV Build Failed with Spark 2.1, Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/307/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] carbondata pull request #1298: [CARBONDATA-1430] Resolved Split Partition Bu...
Posted by xuchuanyin <gi...@git.apache.org>.
Github user xuchuanyin commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1298#discussion_r136225347
--- Diff: integration/spark-common/src/main/scala/org/apache/carbondata/spark/util/CommonUtil.scala ---
@@ -347,7 +347,7 @@ object CommonUtil {
sys.error("The size of new list must be smaller than original list, please check again!")
}
val tempList = newListInfo.mkString(",").split(",")
--- End diff --
Is it necessary to do `list.mkString.split`?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] carbondata pull request #1298: [CARBONDATA-1430] Resolved Split Partition Bu...
Posted by xuchuanyin <gi...@git.apache.org>.
Github user xuchuanyin commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1298#discussion_r136286067
--- Diff: integration/spark-common/src/main/scala/org/apache/carbondata/spark/util/CommonUtil.scala ---
@@ -347,7 +347,7 @@ object CommonUtil {
sys.error("The size of new list must be smaller than original list, please check again!")
}
val tempList = newListInfo.mkString(",").split(",")
--- End diff --
thanks, learned from this... :+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] carbondata pull request #1298: [CARBONDATA-1430] Resolved Split Partition Bu...
Posted by nehabhardwaj01 <gi...@git.apache.org>.
Github user nehabhardwaj01 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1298#discussion_r136273861
--- Diff: integration/spark-common/src/main/scala/org/apache/carbondata/spark/util/CommonUtil.scala ---
@@ -347,7 +347,7 @@ object CommonUtil {
sys.error("The size of new list must be smaller than original list, please check again!")
}
val tempList = newListInfo.mkString(",").split(",")
--- End diff --
Actually, the List on which these functions are being performed stores values as a List[String]
Suppose the list has the following values: ('Korea', 'China', '(Japan, US, Africa)' , 'UK')
Without applying any function the list elements will be :
list(0) => Korea
list(1) => China
list(2) => (Japan, US, Africa) //This list of elements is stored like a string
list(3) => UK
But When we perform list.mkString(",").split(",")
The list now have every element as individual value
list(0) => Korea
list(1) => China
list(2) => (Japan
list(3) => US
list(4) => Africa)
list(5) => UK
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] carbondata issue #1298: [CARBONDATA-1430] Resolved Split Partition Bug When ...
Posted by sraghunandan <gi...@git.apache.org>.
Github user sraghunandan commented on the issue:
https://github.com/apache/carbondata/pull/1298
please add a test case
---
[GitHub] carbondata issue #1298: [CARBONDATA-1430] Resolved Split Partition Bug When ...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1298
SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/574/
---
[GitHub] carbondata issue #1298: [CARBONDATA-1430] Resolved Split Partition Bug When ...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1298
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/511/
---
[GitHub] carbondata issue #1298: [CARBONDATA-1430] Resolved Split Partition Bug When ...
Posted by jackylk <gi...@git.apache.org>.
Github user jackylk commented on the issue:
https://github.com/apache/carbondata/pull/1298
LGTM
---
[GitHub] carbondata issue #1298: [CARBONDATA-1430] Resolved Split Partition Bug When ...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1298
SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/575/
---
[GitHub] carbondata pull request #1298: [CARBONDATA-1430] Resolved Split Partition Bu...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/carbondata/pull/1298
---