You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@thrift.apache.org by GitBox <gi...@apache.org> on 2021/12/02 22:18:08 UTC

[GitHub] [thrift] bhalchandrap opened a new pull request #2484: THRIFT-5486 : fix issues found by spotbugs

bhalchandrap opened a new pull request #2484:
URL: https://github.com/apache/thrift/pull/2484


   Fixes the following issues found by spotbugs:
   
   1. Private method org.apache.thrift.partial.ThriftMetadata$ThriftPrimitive.getParentStruct() is never called
   2. Private method org.apache.thrift.TDeserializer.createNewStruct(ThriftMetadata$ThriftStruct) is never called
   3. org.apache.thrift.partial.PartialThriftComparer.areEqual(ThriftMetadata$ThriftMap, Object, Object, StringBuilder) makes inefficient use of keySet iterator instead of entrySet iterator


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@thrift.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [thrift] Jens-G merged pull request #2484: THRIFT-5486 : fix issues found by spotbugs

Posted by GitBox <gi...@apache.org>.

Jens-G merged pull request #2484:
URL: https://github.com/apache/thrift/pull/2484


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@thrift.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org