[GitHub] [spark] maropu commented on a change in pull request #28991: [SPARK-26533][SQL][test-hive1.2][test-hadoop2.7] Support query auto timeout cancel on thriftserver

[GitBox <gi...@apache.org>]

maropu commented on a change in pull request #28991:
URL: https://github.com/apache/spark/pull/28991#discussion_r450058327



##########
File path: sql/hive-thriftserver/src/test/scala/org/apache/spark/sql/hive/thriftserver/HiveThriftServer2Suites.scala
##########
@@ -874,6 +874,22 @@ class HiveThriftBinaryServerSuite extends HiveThriftJdbcTest {
       assert(rs.getString(1) === expected.toString)
     }
   }
+
+  test("SPARK-26533: Support query auto timeout cancel on thriftserver") {

Review comment:
       Could you check if it can throw an exception (when hive1.2 used internally) by using `HiveUtils.builtinHiveVersion` or the other related variables?
   
   https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125039/testReport/org.apache.spark.sql.hive.thriftserver/HiveThriftBinaryServerSuite/SPARK_26533__Support_query_auto_timeout_cancel_on_thriftserver/
   ```
   Error Message
   java.sql.SQLException: Method not supported
   Stacktrace
   sbt.ForkMain$ForkError: java.sql.SQLException: Method not supported
   	at org.apache.hive.jdbc.HiveStatement.setQueryTimeout(HiveStatement.java:739)
   	at org.apache.spark.sql.hive.thriftserver.HiveThriftBinaryServerSuite.$anonfun$new$97(HiveThriftServer2Suites.scala:880)
   	at 
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org