You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by pascal-bach <gi...@git.apache.org> on 2014/06/05 10:38:07 UTC

[GitHub] thrift pull request: Introduce file to specify third party library...

GitHub user pascal-bach opened a pull request:

    https://github.com/apache/thrift/pull/132

    Introduce file to specify third party library locations on Windows

    This change makes it simpler to specify the location of third party libraries on Windows

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/siemens/thrift winbuild

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/thrift/pull/132.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #132
    
----
commit f55437d55549ced475092518f432936c4e760639
Author: Pascal Bach <pa...@siemens.com>
Date:   2014-04-09T09:19:18Z

    TPipeServer requires OverlappedSubmissionThread.cpp|h
    
    so include it in the corresponding VS files

commit 63a3309a83e6fb09b589a61fe56c5abe1157acb5
Author: Pascal Bach <pa...@siemens.com>
Date:   2014-03-26T15:44:07Z

    Replace Env variables for 3rdparty

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift pull request: Introduce file to specify third party library...

Posted by bufferoverflow <gi...@git.apache.org>.
Github user bufferoverflow commented on the pull request:

    https://github.com/apache/thrift/pull/132#issuecomment-45207908
  
    Hi Pascal
    thanks for the patch!
    please create a related Jira Issue, see http://thrift.apache.org/docs/HowToContribute and I will take care on it.
    -roger


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift pull request: Introduce file to specify third party library...

Posted by pascal-bach <gi...@git.apache.org>.
Github user pascal-bach closed the pull request at:

    https://github.com/apache/thrift/pull/132


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---