You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Mike Percy (Code Review)" <ge...@cloudera.org> on 2016/10/04 10:54:35 UTC

[kudu-CR] WIP: consensus: refactor tracking of received OpIds out of ReplicaState

Mike Percy has posted comments on this change.

Change subject: WIP: consensus: refactor tracking of received OpIds out of ReplicaState
......................................................................


Patch Set 1: Code-Review+1

(3 comments)

looks like a good change

http://gerrit.cloudera.org:8080/#/c/4476/1/src/kudu/consensus/consensus_queue.h
File src/kudu/consensus/consensus_queue.h:

PS1, Line 193: queue
...assuming the term remains the same


http://gerrit.cloudera.org:8080/#/c/4476/1/src/kudu/consensus/raft_consensus_quorum-test.cc
File src/kudu/consensus/raft_consensus_quorum-test.cc:

Line 294:         if (OpIdCompare(peer->queue_->GetLastOpIdInLog(), to_wait_for) >= 0) {
I know this is just a test but it looks like there is no longer a need to take the replica state lock.


http://gerrit.cloudera.org:8080/#/c/4476/1/src/kudu/consensus/raft_consensus_state.cc
File src/kudu/consensus/raft_consensus_state.cc:

PS1, Line 656: ShortDebugString
nit: nicer to use OpIdToString()


-- 
To view, visit http://gerrit.cloudera.org:8080/4476
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I81614d26328b0fbba37bf279f59717e05a07b816
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes