[GitHub] [geode] mkevo commented on a change in pull request #6225: GEODE-9101: fix VisibleNode attribute in MemberMXBean

[GitBox <gi...@apache.org>]

mkevo commented on a change in pull request #6225:
URL: https://github.com/apache/geode/pull/6225#discussion_r605461051



##########
File path: geode-core/src/main/java/org/apache/geode/distributed/internal/ClusterDistributionManager.java
##########
@@ -1881,9 +1881,8 @@ public void handleManagerDeparture(InternalDistributedMember theId, boolean memb
     removeHostedLocators(theId);
     redundancyZones.remove(theId);
 
-    if (theId.getVmKind() != ClusterDistributionManager.LOCATOR_DM_TYPE) {
-      stats.incNodes(-1);
-    }
+    stats.incNodes(-1);
+

Review comment:
       I don't want to change "nodes" to show the number of "servers".
   How it works by now?
   If we have 2 locators and 2 servers the VisibleNodes attribute has the following values:
   ```
   Locator 1: 2 (count Server 1 and Server 2)
   Locator 2: 2 (count Server 1 and Server 2)
   Server 1: 3 (count Server 2, and twice Server 1)
   Server 2: 3 (count  Server 1, and twice Server 2)
   ```
   
   With my changes it will count every member without itself:
   ```
   Locator 1: 3 (count Locator 2, Server 1, and Server 2)
   Locator 2: 3 (count Locator 1, Server 1, and Server 2)
   Server 1: 3 (count Locator 1, Locator 2, and Server 2)
   Server 2: 3 (count Locator 1, Locator 2, and Server 1)
   ```
   What do you mean by the number of "peer-to-peer" processes in the cluster? 
   Is that include both locators and servers?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org