You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Chi Zhang <ch...@gmail.com> on 2015/04/08 04:29:00 UTC
Review Request 32955: Simplified ROOT_CGROUPS_Listen test.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32955/
-----------------------------------------------------------
Review request for mesos, Ian Downes and Jie Yu.
Bugs: mesos-2573
https://issues.apache.org/jira/browse/mesos-2573
Repository: mesos
Description
-------
Simplified ROOT_CGROUPS_Listen test.
Diffs
-----
src/tests/cgroups_tests.cpp e18aed1feca182da89a117f81bed0897a00fb0ef
Diff: https://reviews.apache.org/r/32955/diff/
Testing
-------
Thanks,
Chi Zhang
Re: Review Request 32955: Simplified ROOT_CGROUPS_Listen test.
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32955/#review79294
-----------------------------------------------------------
Patch looks great!
Reviews applied: [32955]
All tests passed.
- Mesos ReviewBot
On April 8, 2015, 2:29 a.m., Chi Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32955/
> -----------------------------------------------------------
>
> (Updated April 8, 2015, 2:29 a.m.)
>
>
> Review request for mesos, Ian Downes and Jie Yu.
>
>
> Bugs: mesos-2573
> https://issues.apache.org/jira/browse/mesos-2573
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Simplified ROOT_CGROUPS_Listen test.
>
>
> Diffs
> -----
>
> src/tests/cgroups_tests.cpp e18aed1feca182da89a117f81bed0897a00fb0ef
>
> Diff: https://reviews.apache.org/r/32955/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Chi Zhang
>
>
Re: Review Request 32955: Simplified ROOT_CGROUPS_Listen test.
Posted by Chi Zhang <ch...@gmail.com>.
> On April 8, 2015, 6:44 p.m., Jie Yu wrote:
> > src/tests/cgroups_tests.cpp, lines 539-542
> > <https://reviews.apache.org/r/32955/diff/1/?file=920415#file920415line539>
> >
> > Any reason you want to remove this?
Disabling it makes the subprocess hang and not return from increaseRSS so the test hangs too.
I could either change the method to not wait, or let the subprocess get killed; the latter seems that it won't affecting testing the future.
- Chi
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32955/#review79395
-----------------------------------------------------------
On April 9, 2015, 10:08 p.m., Chi Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32955/
> -----------------------------------------------------------
>
> (Updated April 9, 2015, 10:08 p.m.)
>
>
> Review request for mesos, Ian Downes and Jie Yu.
>
>
> Bugs: mesos-2573
> https://issues.apache.org/jira/browse/mesos-2573
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Simplified ROOT_CGROUPS_Listen test.
>
>
> Diffs
> -----
>
> src/tests/cgroups_tests.cpp e18aed1feca182da89a117f81bed0897a00fb0ef
>
> Diff: https://reviews.apache.org/r/32955/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Chi Zhang
>
>
Re: Review Request 32955: Simplified ROOT_CGROUPS_Listen test.
Posted by Jie Yu <yu...@gmail.com>.
> On April 8, 2015, 6:44 p.m., Jie Yu wrote:
> > src/tests/cgroups_tests.cpp, lines 539-542
> > <https://reviews.apache.org/r/32955/diff/1/?file=920415#file920415line539>
> >
> > Any reason you want to remove this?
>
> Chi Zhang wrote:
> Disabling it makes the subprocess hang and not return from increaseRSS so the test hangs too.
>
> I could either change the method to not wait, or let the subprocess get killed; the latter seems that it won't affecting testing the future.
I guess that's fine. Maybe add a comment here explaining why you want to keep the oop killer enabled (just like you said above).
- Jie
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32955/#review79395
-----------------------------------------------------------
On April 9, 2015, 10:08 p.m., Chi Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32955/
> -----------------------------------------------------------
>
> (Updated April 9, 2015, 10:08 p.m.)
>
>
> Review request for mesos, Ian Downes and Jie Yu.
>
>
> Bugs: mesos-2573
> https://issues.apache.org/jira/browse/mesos-2573
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Simplified ROOT_CGROUPS_Listen test.
>
>
> Diffs
> -----
>
> src/tests/cgroups_tests.cpp e18aed1feca182da89a117f81bed0897a00fb0ef
>
> Diff: https://reviews.apache.org/r/32955/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Chi Zhang
>
>
Re: Review Request 32955: Simplified ROOT_CGROUPS_Listen test.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32955/#review79395
-----------------------------------------------------------
Ship it!
Great cleanup!
src/tests/cgroups_tests.cpp
<https://reviews.apache.org/r/32955/#comment128705>
Any reason you want to remove this?
src/tests/cgroups_tests.cpp
<https://reviews.apache.org/r/32955/#comment128703>
Use AWAIT_READY?
- Jie Yu
On April 8, 2015, 2:29 a.m., Chi Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32955/
> -----------------------------------------------------------
>
> (Updated April 8, 2015, 2:29 a.m.)
>
>
> Review request for mesos, Ian Downes and Jie Yu.
>
>
> Bugs: mesos-2573
> https://issues.apache.org/jira/browse/mesos-2573
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Simplified ROOT_CGROUPS_Listen test.
>
>
> Diffs
> -----
>
> src/tests/cgroups_tests.cpp e18aed1feca182da89a117f81bed0897a00fb0ef
>
> Diff: https://reviews.apache.org/r/32955/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Chi Zhang
>
>
Re: Review Request 32955: Simplified ROOT_CGROUPS_Listen test.
Posted by Ian Downes <ia...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32955/#review79400
-----------------------------------------------------------
Ship it!
src/tests/cgroups_tests.cpp
<https://reviews.apache.org/r/32955/#comment128710>
Not yours, but isn't 512 overkill :-) if the limit is 64 then anything >= 64 MB should trigger it? How about actually tying it to the limit, e.g., 2*limit?
- Ian Downes
On April 7, 2015, 7:29 p.m., Chi Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32955/
> -----------------------------------------------------------
>
> (Updated April 7, 2015, 7:29 p.m.)
>
>
> Review request for mesos, Ian Downes and Jie Yu.
>
>
> Bugs: mesos-2573
> https://issues.apache.org/jira/browse/mesos-2573
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Simplified ROOT_CGROUPS_Listen test.
>
>
> Diffs
> -----
>
> src/tests/cgroups_tests.cpp e18aed1feca182da89a117f81bed0897a00fb0ef
>
> Diff: https://reviews.apache.org/r/32955/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Chi Zhang
>
>
Re: Review Request 32955: Simplified ROOT_CGROUPS_Listen test.
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32955/#review79590
-----------------------------------------------------------
Patch looks great!
Reviews applied: [32955]
All tests passed.
- Mesos ReviewBot
On April 9, 2015, 10:08 p.m., Chi Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32955/
> -----------------------------------------------------------
>
> (Updated April 9, 2015, 10:08 p.m.)
>
>
> Review request for mesos, Ian Downes and Jie Yu.
>
>
> Bugs: mesos-2573
> https://issues.apache.org/jira/browse/mesos-2573
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Simplified ROOT_CGROUPS_Listen test.
>
>
> Diffs
> -----
>
> src/tests/cgroups_tests.cpp e18aed1feca182da89a117f81bed0897a00fb0ef
>
> Diff: https://reviews.apache.org/r/32955/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Chi Zhang
>
>
Re: Review Request 32955: Simplified ROOT_CGROUPS_Listen test.
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32955/#review79622
-----------------------------------------------------------
Patch looks great!
Reviews applied: [32955]
All tests passed.
- Mesos ReviewBot
On April 10, 2015, 12:45 a.m., Chi Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32955/
> -----------------------------------------------------------
>
> (Updated April 10, 2015, 12:45 a.m.)
>
>
> Review request for mesos, Ian Downes and Jie Yu.
>
>
> Bugs: mesos-2573
> https://issues.apache.org/jira/browse/mesos-2573
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Simplified ROOT_CGROUPS_Listen test.
>
>
> Diffs
> -----
>
> src/tests/cgroups_tests.cpp e18aed1feca182da89a117f81bed0897a00fb0ef
>
> Diff: https://reviews.apache.org/r/32955/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Chi Zhang
>
>
Re: Review Request 32955: Simplified ROOT_CGROUPS_Listen test.
Posted by Chi Zhang <ch...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32955/
-----------------------------------------------------------
(Updated April 10, 2015, 12:45 a.m.)
Review request for mesos, Ian Downes and Jie Yu.
Bugs: mesos-2573
https://issues.apache.org/jira/browse/mesos-2573
Repository: mesos
Description
-------
Simplified ROOT_CGROUPS_Listen test.
Diffs (updated)
-----
src/tests/cgroups_tests.cpp e18aed1feca182da89a117f81bed0897a00fb0ef
Diff: https://reviews.apache.org/r/32955/diff/
Testing
-------
Thanks,
Chi Zhang
Re: Review Request 32955: Simplified ROOT_CGROUPS_Listen test.
Posted by Chi Zhang <ch...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32955/
-----------------------------------------------------------
(Updated April 9, 2015, 10:08 p.m.)
Review request for mesos, Ian Downes and Jie Yu.
Bugs: mesos-2573
https://issues.apache.org/jira/browse/mesos-2573
Repository: mesos
Description
-------
Simplified ROOT_CGROUPS_Listen test.
Diffs (updated)
-----
src/tests/cgroups_tests.cpp e18aed1feca182da89a117f81bed0897a00fb0ef
Diff: https://reviews.apache.org/r/32955/diff/
Testing
-------
Thanks,
Chi Zhang
Re: Review Request 32955: Simplified ROOT_CGROUPS_Listen test.
Posted by Chi Zhang <ch...@gmail.com>.
> On April 8, 2015, 6:59 p.m., Ian Downes wrote:
> > src/tests/cgroups_tests.cpp, lines 559-561
> > <https://reviews.apache.org/r/32955/diff/1/?file=920415#file920415line559>
> >
> > Do you need to reap this process?
it's done in helper's dtor.
- Chi
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32955/#review79403
-----------------------------------------------------------
On April 9, 2015, 10:08 p.m., Chi Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32955/
> -----------------------------------------------------------
>
> (Updated April 9, 2015, 10:08 p.m.)
>
>
> Review request for mesos, Ian Downes and Jie Yu.
>
>
> Bugs: mesos-2573
> https://issues.apache.org/jira/browse/mesos-2573
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Simplified ROOT_CGROUPS_Listen test.
>
>
> Diffs
> -----
>
> src/tests/cgroups_tests.cpp e18aed1feca182da89a117f81bed0897a00fb0ef
>
> Diff: https://reviews.apache.org/r/32955/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Chi Zhang
>
>
Re: Review Request 32955: Simplified ROOT_CGROUPS_Listen test.
Posted by Ian Downes <ia...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32955/#review79403
-----------------------------------------------------------
src/tests/cgroups_tests.cpp
<https://reviews.apache.org/r/32955/#comment128717>
Do you need to reap this process?
- Ian Downes
On April 7, 2015, 7:29 p.m., Chi Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32955/
> -----------------------------------------------------------
>
> (Updated April 7, 2015, 7:29 p.m.)
>
>
> Review request for mesos, Ian Downes and Jie Yu.
>
>
> Bugs: mesos-2573
> https://issues.apache.org/jira/browse/mesos-2573
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Simplified ROOT_CGROUPS_Listen test.
>
>
> Diffs
> -----
>
> src/tests/cgroups_tests.cpp e18aed1feca182da89a117f81bed0897a00fb0ef
>
> Diff: https://reviews.apache.org/r/32955/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Chi Zhang
>
>