You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Gastón Kleiman <ga...@mesosphere.io> on 2017/08/05 00:06:48 UTC
Review Request 61438: Improved
`NvidiaGpuTest.ROOT_CGROUPS_NVIDIA_GPU_VerifyDeviceAccess`.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61438/
-----------------------------------------------------------
Review request for mesos, Kevin Klues and Vinod Kone.
Repository: mesos
Description
-------
Change the test so that the agent offesr as many GPUs as available on
the box instead of restricting it to 1. This way the test will fail if
there's a bug that makes the isolator give a task access to more GPUs
than what it was allocated.
Diffs
-----
src/tests/containerizer/nvidia_gpu_isolator_tests.cpp 9a78ae65c1cd414b5093b54ff51724e31e31c9d3
Diff: https://reviews.apache.org/r/61438/diff/1/
Testing
-------
`GLOG_v=1 sudo bin/mesos-tests.sh --gtest_filter="*NvidiaGpuTest.*Verify*" --verbose` passed on a machine with 4 Nvidia GPUs.
Thanks,
Gastón Kleiman
Re: Review Request 61438: Improved
`NvidiaGpuTest.ROOT_CGROUPS_NVIDIA_GPU_VerifyDeviceAccess`.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61438/#review182415
-----------------------------------------------------------
Ship it!
Ship It!
- Vinod Kone
On Aug. 5, 2017, 12:06 a.m., Gastón Kleiman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61438/
> -----------------------------------------------------------
>
> (Updated Aug. 5, 2017, 12:06 a.m.)
>
>
> Review request for mesos, Kevin Klues and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Change the test so that the agent offesr as many GPUs as available on
> the box instead of restricting it to 1. This way the test will fail if
> there's a bug that makes the isolator give a task access to more GPUs
> than what it was allocated.
>
>
> Diffs
> -----
>
> src/tests/containerizer/nvidia_gpu_isolator_tests.cpp 9a78ae65c1cd414b5093b54ff51724e31e31c9d3
>
>
> Diff: https://reviews.apache.org/r/61438/diff/1/
>
>
> Testing
> -------
>
> `GLOG_v=1 sudo bin/mesos-tests.sh --gtest_filter="*NvidiaGpuTest.*Verify*" --verbose` passed on a machine with 4 Nvidia GPUs.
>
>
> Thanks,
>
> Gastón Kleiman
>
>