You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Ramesh Mani <rm...@hortonworks.com> on 2015/04/08 07:53:28 UTC
Review Request 32959: PublicAPI should support search for service and
policy with non case sensitive serviceType
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32959/
-----------------------------------------------------------
Review request for ranger, Alok Lal, Don Bosco Durai, dilli dorai, Madhan Neethiraj, and Selvamohan Neethiraj.
Repository: ranger
Description
-------
PublicAPI should support search for service and policy with non case sensitive serviceType
Diffs
-----
security-admin/src/main/java/org/apache/ranger/common/RangerSearchUtil.java 1a45d43
security-admin/src/main/java/org/apache/ranger/rest/PublicAPIs.java cd31f69
security-admin/src/main/java/org/apache/ranger/rest/ServiceREST.java c85422c
Diff: https://reviews.apache.org/r/32959/diff/
Testing
-------
Testing done in local vagrant environment
curl -i -X GET --header "Accept:application/json" -H "Content-Type: application/json" -u admin:admin http://ranger-yarn.example.com:6080/service/public/api/repository?type=hdfs
curl -i -X GET --header "Accept:application/json" -H "Content-Type: application/json" -u admin:admin http://ranger-yarn.example.com:6080/service/public/api/repository?type=HDFS
curl -i -X GET --header "Accept:application/json" -H "Content-Type: application/json" -u admin:admin http://ranger-yarn.example.com:6080/service/public/api/policy?repositoryType=Hdfs
Thanks,
Ramesh Mani
Re: Review Request 32959: PublicAPI should support search for service
and policy with non case sensitive serviceType
Posted by Selvamohan Neethiraj <sn...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32959/#review79315
-----------------------------------------------------------
Ship it!
Ship It!
- Selvamohan Neethiraj
On April 8, 2015, 1:53 a.m., Ramesh Mani wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32959/
> -----------------------------------------------------------
>
> (Updated April 8, 2015, 1:53 a.m.)
>
>
> Review request for ranger, Alok Lal, Don Bosco Durai, dilli dorai, Madhan Neethiraj, and Selvamohan Neethiraj.
>
>
> Repository: ranger
>
>
> Description
> -------
>
> PublicAPI should support search for service and policy with non case sensitive serviceType
>
>
> Diffs
> -----
>
> security-admin/src/main/java/org/apache/ranger/common/RangerSearchUtil.java 1a45d43
> security-admin/src/main/java/org/apache/ranger/rest/PublicAPIs.java cd31f69
> security-admin/src/main/java/org/apache/ranger/rest/ServiceREST.java c85422c
>
> Diff: https://reviews.apache.org/r/32959/diff/
>
>
> Testing
> -------
>
> Testing done in local vagrant environment
>
>
> curl -i -X GET --header "Accept:application/json" -H "Content-Type: application/json" -u admin:admin http://ranger-yarn.example.com:6080/service/public/api/repository?type=hdfs
>
> curl -i -X GET --header "Accept:application/json" -H "Content-Type: application/json" -u admin:admin http://ranger-yarn.example.com:6080/service/public/api/repository?type=HDFS
>
> curl -i -X GET --header "Accept:application/json" -H "Content-Type: application/json" -u admin:admin http://ranger-yarn.example.com:6080/service/public/api/policy?repositoryType=Hdfs
>
>
> Thanks,
>
> Ramesh Mani
>
>
Re: Review Request 32959: PublicAPI should support search for service
and policy with non case sensitive serviceType
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32959/#review79312
-----------------------------------------------------------
security-admin/src/main/java/org/apache/ranger/common/RangerSearchUtil.java
<https://reviews.apache.org/r/32959/#comment128571>
if request doesn't have repositoryType parameter, this will result in NPE. Please handle this condition.
- Madhan Neethiraj
On April 8, 2015, 5:53 a.m., Ramesh Mani wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32959/
> -----------------------------------------------------------
>
> (Updated April 8, 2015, 5:53 a.m.)
>
>
> Review request for ranger, Alok Lal, Don Bosco Durai, dilli dorai, Madhan Neethiraj, and Selvamohan Neethiraj.
>
>
> Repository: ranger
>
>
> Description
> -------
>
> PublicAPI should support search for service and policy with non case sensitive serviceType
>
>
> Diffs
> -----
>
> security-admin/src/main/java/org/apache/ranger/common/RangerSearchUtil.java 1a45d43
> security-admin/src/main/java/org/apache/ranger/rest/PublicAPIs.java cd31f69
> security-admin/src/main/java/org/apache/ranger/rest/ServiceREST.java c85422c
>
> Diff: https://reviews.apache.org/r/32959/diff/
>
>
> Testing
> -------
>
> Testing done in local vagrant environment
>
>
> curl -i -X GET --header "Accept:application/json" -H "Content-Type: application/json" -u admin:admin http://ranger-yarn.example.com:6080/service/public/api/repository?type=hdfs
>
> curl -i -X GET --header "Accept:application/json" -H "Content-Type: application/json" -u admin:admin http://ranger-yarn.example.com:6080/service/public/api/repository?type=HDFS
>
> curl -i -X GET --header "Accept:application/json" -H "Content-Type: application/json" -u admin:admin http://ranger-yarn.example.com:6080/service/public/api/policy?repositoryType=Hdfs
>
>
> Thanks,
>
> Ramesh Mani
>
>