You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by GitBox <gi...@apache.org> on 2022/07/02 14:56:47 UTC
[GitHub] [incubator-seatunnel] gleiyu opened a new pull request, #2118: [Bug] [seatunnel-connector-flink-fake] Type is not supported: BigInteger
gleiyu opened a new pull request, #2118:
URL: https://github.com/apache/incubator-seatunnel/pull/2118
<!--
Thank you for contributing to SeaTunnel! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
## Contribution Checklist
- Make sure that the pull request corresponds to a [GITHUB issue](https://github.com/apache/incubator-seatunnel/issues).
- Name the pull request in the form "[Feature] [component] Title of the pull request", where *Feature* can be replaced by `Hotfix`, `Bug`, etc.
- Minor fixes should be named following this pattern: `[hotfix] [docs] Fix typo in README.md doc`.
-->
## Purpose of this pull request
fix : https://github.com/apache/incubator-seatunnel/issues/2114
## Check list
* [ ] Code changed are covered with tests, or it does not need tests for reason:
* [ ] If any new Jar binary package adding in your PR, please add License Notice according
[New License Guide](https://github.com/apache/incubator-seatunnel/blob/dev/docs/en/contribution/new-license.md)
* [ ] If necessary, please update the documentation to describe the new feature. https://github.com/apache/incubator-seatunnel/tree/dev/docs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] gleiyu commented on a diff in pull request #2118: [Bug] [seatunnel-connector-flink-fake] Type is not supported: BigInteger
Posted by GitBox <gi...@apache.org>.
gleiyu commented on code in PR #2118:
URL: https://github.com/apache/incubator-seatunnel/pull/2118#discussion_r912427760
##########
seatunnel-connectors/seatunnel-connectors-flink/seatunnel-connector-flink-fake/src/main/java/org/apache/seatunnel/flink/fake/source/MockSchema.java:
##########
@@ -132,6 +132,7 @@ public TypeInformation<?> typeInformation() {
dataType = BasicTypeInfo.SHORT_TYPE_INFO;
break;
case "long":
+ case "bigint":
Review Comment:
it's still not work until change TypeInformation defined in line 154 `dataType = BasicTypeInfo.LONG_TYPE_INFO;`
so can we remove biginteger and set bigint as same as long ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] ruanwenjun commented on a diff in pull request #2118: [Bug] [seatunnel-connector-flink-fake] Type is not supported: BigInteger
Posted by GitBox <gi...@apache.org>.
ruanwenjun commented on code in PR #2118:
URL: https://github.com/apache/incubator-seatunnel/pull/2118#discussion_r912421310
##########
seatunnel-connectors/seatunnel-connectors-flink/seatunnel-connector-flink-fake/src/main/java/org/apache/seatunnel/flink/fake/source/MockSchema.java:
##########
@@ -132,6 +132,7 @@ public TypeInformation<?> typeInformation() {
dataType = BasicTypeInfo.SHORT_TYPE_INFO;
break;
case "long":
+ case "bigint":
Review Comment:
Yes, use bigint is better, and I check the [seatunnel doc](https://seatunnel.apache.org/docs/2.1.2/connector/source/Fake#mock_data_schema-option--listcolumn_config), there are already support bigint.
You get the error is due to ST will generate BigInteger but flink doesn't support BitInteger, so you need to change the line 239.
```java
mockData = JMockData.mock(Long.class, mockConfig);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] ruanwenjun commented on a diff in pull request #2118: [Bug] [seatunnel-connector-flink-fake] Type is not supported: BigInteger
Posted by GitBox <gi...@apache.org>.
ruanwenjun commented on code in PR #2118:
URL: https://github.com/apache/incubator-seatunnel/pull/2118#discussion_r912374515
##########
seatunnel-connectors/seatunnel-connectors-flink/seatunnel-connector-flink-fake/src/main/java/org/apache/seatunnel/flink/fake/source/MockSchema.java:
##########
@@ -132,6 +132,7 @@ public TypeInformation<?> typeInformation() {
dataType = BasicTypeInfo.SHORT_TYPE_INFO;
break;
case "long":
+ case "bigint":
Review Comment:
I don't think we need to add `bigint`, since we already has `BigInteger`, and I see the [Jmock doc](https://github.com/jsonzou/jmockdata#java对象), they did support `bigint`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] gleiyu commented on a diff in pull request #2118: [Bug] [seatunnel-connector-flink-fake] Type is not supported: BigInteger
Posted by GitBox <gi...@apache.org>.
gleiyu commented on code in PR #2118:
URL: https://github.com/apache/incubator-seatunnel/pull/2118#discussion_r912377612
##########
seatunnel-connectors/seatunnel-connectors-flink/seatunnel-connector-flink-fake/src/main/java/org/apache/seatunnel/flink/fake/source/MockSchema.java:
##########
@@ -132,6 +132,7 @@ public TypeInformation<?> typeInformation() {
dataType = BasicTypeInfo.SHORT_TYPE_INFO;
break;
case "long":
+ case "bigint":
Review Comment:
I think that most users of seatunnel are data developers , they are more familiar with the data types in the database and may not know java at all .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] gleiyu commented on a diff in pull request #2118: [Bug] [seatunnel-connector-flink-fake] Type is not supported: BigInteger
Posted by GitBox <gi...@apache.org>.
gleiyu commented on code in PR #2118:
URL: https://github.com/apache/incubator-seatunnel/pull/2118#discussion_r912376699
##########
seatunnel-connectors/seatunnel-connectors-flink/seatunnel-connector-flink-fake/src/main/java/org/apache/seatunnel/flink/fake/source/MockSchema.java:
##########
@@ -132,6 +132,7 @@ public TypeInformation<?> typeInformation() {
dataType = BasicTypeInfo.SHORT_TYPE_INFO;
break;
case "long":
+ case "bigint":
Review Comment:
i have try to using biginteger and produces the same error.
as a data developer, i usually used bigint in data warehouse , and it's as same as long in java .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] ruanwenjun commented on a diff in pull request #2118: [Bug] [seatunnel-connector-flink-fake] Type is not supported: BigInteger
Posted by GitBox <gi...@apache.org>.
ruanwenjun commented on code in PR #2118:
URL: https://github.com/apache/incubator-seatunnel/pull/2118#discussion_r912428525
##########
seatunnel-connectors/seatunnel-connectors-flink/seatunnel-connector-flink-fake/src/main/java/org/apache/seatunnel/flink/fake/source/MockSchema.java:
##########
@@ -132,6 +132,7 @@ public TypeInformation<?> typeInformation() {
dataType = BasicTypeInfo.SHORT_TYPE_INFO;
break;
case "long":
+ case "bigint":
Review Comment:
I think we can, the BigInteger cannot work may due to the version of table api.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] ruanwenjun merged pull request #2118: [Bug] [seatunnel-connector-flink-fake] Type is not supported: BigInteger
Posted by GitBox <gi...@apache.org>.
ruanwenjun merged PR #2118:
URL: https://github.com/apache/incubator-seatunnel/pull/2118
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org