You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "morningman (via GitHub)" <gi...@apache.org> on 2023/03/09 06:25:21 UTC
[GitHub] [doris] morningman opened a new pull request, #17602: [fix](meta) fix concurrent modification exception and potential NPE
morningman opened a new pull request, #17602:
URL: https://github.com/apache/doris/pull/17602
# Proposed changes
Issue Number: close #xxx
## Problem summary
Fix 2 bugs:
1.
```
java.util.ConcurrentModificationException: null
at java.util.HashMap$HashIterator.nextNode(HashMap.java:1442) ~[?:1.8.0_191]
at java.util.HashMap$EntryIterator.next(HashMap.java:1476) ~[?:1.8.0_191]
at java.util.HashMap$EntryIterator.next(HashMap.java:1474) ~[?:1.8.0_191]
at java.util.AbstractMap.hashCode(AbstractMap.java:530) ~[?:1.8.0_191]
at java.util.Arrays.hashCode(Arrays.java:4146) ~[?:1.8.0_191]
at java.util.Objects.hash(Objects.java:128) ~[?:1.8.0_191]
at org.apache.doris.catalog.PartitionInfo.hashCode(PartitionInfo.java:400) ~[doris-fe.jar:1.2-SNAPSHOT]
at java.util.Arrays.hashCode(Arrays.java:4146) ~[?:1.8.0_191]
at java.util.Objects.hash(Objects.java:128) ~[?:1.8.0_191]
at org.apache.doris.catalog.OlapTable.hashCode(OlapTable.java:1557) ~[doris-fe.jar:1.2-SNAPSHOT]
at java.util.HashMap.hash(HashMap.java:339) ~[?:1.8.0_191]
at java.util.HashMap.put(HashMap.java:612) ~[?:1.8.0_191]
at java.util.HashSet.add(HashSet.java:220) ~[?:1.8.0_191]
at org.apache.doris.analysis.DescriptorTable.toThrift(DescriptorTable.java:194) ~[doris-fe.jar:1.2-SNAPSHOT]
at org.apache.doris.qe.Coordinator.<init>(Coordinator.java:251) ~[doris-fe.jar:1.2-SNAPSHOT]
at org.apache.doris.qe.StmtExecutor.sendResult(StmtExecutor.java:1135) ~[doris-fe.jar:1.2-SNAPSHOT]
at org.apache.doris.qe.StmtExecutor.handleQueryStmt(StmtExecutor.java:1122) ~[doris-fe.jar:1.2-SNAPSHOT]
java.util.ConcurrentModificationException: null
at java.util.HashMap$HashIterator.nextNode(HashMap.java:1442) ~[?:1.8.0_191]
at java.util.HashMap$EntryIterator.next(HashMap.java:1476) ~[?:1.8.0_191]
at java.util.HashMap$EntryIterator.next(HashMap.java:1474) ~[?:1.8.0_191]
at java.util.AbstractMap.hashCode(AbstractMap.java:530) ~[?:1.8.0_191]
at java.util.Arrays.hashCode(Arrays.java:4146) ~[?:1.8.0_191]
at java.util.Objects.hash(Objects.java:128) ~[?:1.8.0_191]
at org.apache.doris.catalog.PartitionInfo.hashCode(PartitionInfo.java:400) ~[doris-fe.jar:1.2-SNAPSHOT]
at java.util.Arrays.hashCode(Arrays.java:4146) ~[?:1.8.0_191]
at java.util.Objects.hash(Objects.java:128) ~[?:1.8.0_191]
at org.apache.doris.catalog.OlapTable.hashCode(OlapTable.java:1557) ~[doris-fe.jar:1.2-SNAPSHOT]
at java.util.HashMap.hash(HashMap.java:339) ~[?:1.8.0_191]
at java.util.HashMap.put(HashMap.java:612) ~[?:1.8.0_191]
at java.util.HashSet.add(HashSet.java:220) ~[?:1.8.0_191]
at org.apache.doris.analysis.DescriptorTable.toThrift(DescriptorTable.java:194) ~[doris-fe.jar:1.2-SNAPSHOT]
at org.apache.doris.qe.Coordinator.<init>(Coordinator.java:251) ~[doris-fe.jar:1.2-SNAPSHOT]
at org.apache.doris.qe.StmtExecutor.handleInsertStmt(StmtExecutor.java:1464) ~[doris-fe.jar:1.2-SNAPSHOT]
at org.apache.doris.qe.StmtExecutor.execute(StmtExecutor.java:555) ~[doris-fe.jar:1.2-SNAPSHOT]
```
2.
```
java.lang.NullPointerException: null
at org.apache.doris.transaction.GlobalTransactionMgr.existCommittedTxns
```
The second bug's root cause is unclear, I just add a log to observe, and avoid throwing NPE.
## Checklist(Required)
* [ ] Does it affect the original behavior
* [ ] Has unit tests been added
* [ ] Has document been added or modified
* [ ] Does it need to update dependencies
* [ ] Is this PR support rollback (If NO, please explain WHY)
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] morningman commented on pull request #17602: [fix](meta) fix concurrent modification exception and potential NPE
Posted by "morningman (via GitHub)" <gi...@apache.org>.
morningman commented on PR #17602:
URL: https://github.com/apache/doris/pull/17602#issuecomment-1462309933
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] dataroaring merged pull request #17602: [fix](meta) fix concurrent modification exception and potential NPE
Posted by "dataroaring (via GitHub)" <gi...@apache.org>.
dataroaring merged PR #17602:
URL: https://github.com/apache/doris/pull/17602
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org