[PATCH] Be verbose during shl_load on HP-UX

["MATHIHALLI,MADHUSUDAN (HP-Cupertino,ex1)" <ma...@hp.com>]

Hi,
	'wondering if anybody has objections for the below patch. By having
the BIND_VERBOSE option, we can know what really failed during the shl_load.

-Madhu

Index: dso.c
===================================================================
RCS file: /home/cvs/apr/dso/unix/dso.c,v
retrieving revision 1.61
diff -u -r1.61 dso.c
--- dso.c       16 Feb 2003 10:00:08 -0000      1.61
+++ dso.c       28 May 2003 21:43:01 -0000
@@ -119,7 +119,7 @@
                                        const char *path, apr_pool_t *pool)
 {
 #if defined(DSO_USE_SHL)
-    shl_t os_handle = shl_load(path, BIND_IMMEDIATE, 0L);
+    shl_t os_handle = shl_load(path, BIND_IMMEDIATE|BIND_VERBOSE, 0L);
 
 #elif defined(DSO_USE_DYLD)
     NSObjectFileImage image;

Re: [PATCH] Be verbose during shl_load on HP-UX

[Joe Orton <jo...@manyfish.co.uk>]

On Wed, May 28, 2003 at 02:46:28PM -0700, MATHIHALLI,MADHUSUDAN (HP-Cupertino,ex1) wrote:
> 	'wondering if anybody has objections for the below patch. By having
> the BIND_VERBOSE option, we can know what really failed during the shl_load.

Hi Madhu, BIND_VERBOSE was removed on purpose - the defined interface
for retrieving error strings is apr_dso_error() - having one
implementation also spit errors on fd 2 is both inconsistent and
generally a bad idea (since the app may close stderr and open something
else there).

joe

> diff -u -r1.61 dso.c
> --- dso.c       16 Feb 2003 10:00:08 -0000      1.61
> +++ dso.c       28 May 2003 21:43:01 -0000
> @@ -119,7 +119,7 @@
>                                         const char *path, apr_pool_t *pool)
>  {
>  #if defined(DSO_USE_SHL)
> -    shl_t os_handle = shl_load(path, BIND_IMMEDIATE, 0L);
> +    shl_t os_handle = shl_load(path, BIND_IMMEDIATE|BIND_VERBOSE, 0L);
>  
>  #elif defined(DSO_USE_DYLD)
>      NSObjectFileImage image;