You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@avro.apache.org by "Fokko Driesprong (JIRA)" <ji...@apache.org> on 2019/02/12 15:56:00 UTC

[jira] [Assigned] (AVRO-1989) Ruby schema validation for fixed types should use bytesize in error message

     [ https://issues.apache.org/jira/browse/AVRO-1989?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Fokko Driesprong reassigned AVRO-1989:
--------------------------------------

    Assignee: Fokko Driesprong  (was: Sean Busbey)

> Ruby schema validation for fixed types should use bytesize in error message
> ---------------------------------------------------------------------------
>
>                 Key: AVRO-1989
>                 URL: https://issues.apache.org/jira/browse/AVRO-1989
>             Project: Apache Avro
>          Issue Type: Bug
>          Components: ruby
>    Affects Versions: 1.9.0
>            Reporter: Sean Busbey
>            Assignee: Fokko Driesprong
>            Priority: Minor
>             Fix For: 1.9.0
>
>         Attachments: AVRO-1989.0.patch
>
>
> From AVRO-1886:
> I'd like to get one thing improved, but it's fine as a follow-on.
> {code}
>  +       when :fixed
>  +          if datum.is_a? String
>  +            message = "expected fixed with size #{expected_schema.size}, got \"#{datum}\" with size #{datum.size}"
>  +            result.add_error(path, message) unless datum.bytesize == expected_schema.size
>  +          else
>  +            result.add_error(path, "expected fixed with size #{expected_schema.size}, got #{actual_value_message(datum)}")
>  +          end
> {code}
> the message here should use datum.bytesize instead of datum.size.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)