[GitHub] [incubator-iceberg] TGooch44 commented on a change in pull request #544: [python] Adding parquet package which contains classes necessary for …

[GitBox <gi...@apache.org>]

TGooch44 commented on a change in pull request #544: [python] Adding parquet package which contains classes necessary for …
URL: https://github.com/apache/incubator-iceberg/pull/544#discussion_r339253849
 
 

 ##########
 File path: python/iceberg/parquet/parquet_reader.py
 ##########
 @@ -0,0 +1,340 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+from collections import OrderedDict
+from datetime import datetime
+import decimal
+import logging
+
+import fastparquet
 
 Review comment:
   Let me review your code in kartothek because I did want to coalesce on just pyarrow.  I coded a lot of this a year ago, and I think the arrow project has moved quite a bit since then.  It's also possible some of what I was missing was there I just couldn't find it at the time without searching through the c code.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org