[GitHub] [spark] bogao007 commented on a diff in pull request #42280: [SPARK-44626][SS][CONNECT] Followup on streaming query termination when client session is timed out for Spark Connect

["bogao007 (via GitHub)" <gi...@apache.org>]

bogao007 commented on code in PR #42280:
URL: https://github.com/apache/spark/pull/42280#discussion_r1282238281


##########
connector/connect/server/src/main/scala/org/apache/spark/sql/connect/service/SparkConnectStreamingQueryCache.scala:
##########
@@ -182,12 +179,10 @@ private[connect] class SparkConnectStreamingQueryCache(
             log.info(s"Removing references for $id in session ${v.sessionId} after expiry period")
             queryCache.remove(k)
 
-          case Some(_) => // Inactive query waiting for expiration. Keep the session alive.
-            sessionsToKeepAlive.add((v.userId, v.sessionId))
+          case Some(_) => // Inactive query waiting for expiration. Do nothing.
+            log.info(s"Waiting for the expiration for $id in session ${v.sessionId}")

Review Comment:
   Sure, I will update those as well



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org