[GitHub] [accumulo] ctubbsii commented on a diff in pull request #2735: Fix async bug when clearing logs in monitor

[GitBox <gi...@apache.org>]

ctubbsii commented on code in PR #2735:
URL: https://github.com/apache/accumulo/pull/2735#discussion_r887158917


##########
server/monitor/src/main/resources/org/apache/accumulo/monitor/resources/js/functions.js:
##########
@@ -323,7 +323,8 @@ function doLoggedPostCall(call, callback, sanitize) {
   // Make the rest call, passing success function callback
   $.post(call, function () {
     console.debug("REST POST call to " + call + ": success");
-    if (callback !== null) {
+    if (callback !== null && callback !== undefined) {

Review Comment:
   That commit made it `!==`. My suggestion was to use `!=`. They return different answers. `!==` will return `true`, implying this is non-null when it is merely undefined. It should be either: `!=` or it should check if it's defined before it checks if it is null, which are the two suggestions I made above. The commit does not follow either suggestion, and merely removes one case.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org