You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Michael Osipov (Jira)" <ji...@apache.org> on 2021/08/11 08:36:00 UTC
[jira] [Commented] (MSKINS-172) Non-deliberate margin between
navigation and rest in side bar
[ https://issues.apache.org/jira/browse/MSKINS-172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17397184#comment-17397184 ]
Michael Osipov commented on MSKINS-172:
---------------------------------------
Should the second {{div}} be a {{nav}} too?
> Non-deliberate margin between navigation and rest in side bar
> -------------------------------------------------------------
>
> Key: MSKINS-172
> URL: https://issues.apache.org/jira/browse/MSKINS-172
> Project: Maven Skins
> Issue Type: Bug
> Components: Fluido Skin
> Affects Versions: fluido-1.8
> Reporter: Konrad Windszus
> Priority: Major
> Attachments: fluido-1.7.png, fluido-1.9.png
>
>
> Due to the change https://github.com/apache/maven-fluido-skin/commit/f9cbe82ff307c61cefe0336da89eb0082086585a#diff-f1940cd019654c7f2cb1801363b96b62c6526752fa8640c8de042ea4f0f36778R226 introduced with MSKINS-153 there is a margin between the navigation and the google site search bar and the powered by section. For example look at https://jackrabbit.apache.org/filevault-package-maven-plugin/index.html.
> This is caused by the markup change from
> {code}
> <div class="well sidebar-nav">
> ...menu, search bar and powered by
> </div>
> {code} to
> {code}
> <nav class="well sidebar-nav">
> ...menu
> </nav>
> <div class="well sidebar-nav">
> ...search bar and powered by
> </div>
> {code}
> combined with the CSS for class {{sidebar-nav}}: https://github.com/apache/maven-fluido-skin/blob/0cef65c2abd91af3297b2e7ec95790e7b4bfabb0/src/main/resources/css/maven-theme.css#L126
> Example site leveraging fluido 1.9 (https://jackrabbit.apache.org/filevault-package-maven-plugin/index.html):
> !fluido-1.9.png!
> Example site leveraging fluido 1.7 (https://maven.apache.org/plugins/maven-compiler-plugin/index.html referenced in https://github.com/apache/maven-parent/blob/maven-parent-34/src/site/site.xml#L39):
> !fluido-1.7.png!
--
This message was sent by Atlassian Jira
(v8.3.4#803005)