You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/03/22 05:56:05 UTC

[GitHub] [cloudstack] rhtyd commented on a change in pull request #4851: [Vmware] Fix worker VMs hardware version small bug

rhtyd commented on a change in pull request #4851:
URL: https://github.com/apache/cloudstack/pull/4851#discussion_r598441562



##########
File path: vmware-base/src/main/java/com/cloud/hypervisor/vmware/mo/VirtualMachineMO.java
##########
@@ -3292,6 +3292,21 @@ public int getVirtualHardwareVersion() throws Exception {
         return vhOption.getHwVersion();
     }
 
+    /**
+     * Return a hardware version string in the format expected by Vmware
+     * Format: "vmx-DD" where DD represents the hardware version number
+     */
+    public String getVmxFormattedVirtualHardwareVersion() throws Exception {

Review comment:
       Can you add a quick unit test for the same @nvazquez ?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org