cvs commit: xml-soap/java/src/org/apache/soap Fault.java

[du...@apache.org]

duftler     01/05/22 14:59:23

  Modified:    java/src/org/apache/soap Fault.java
  Log:
  Removed patch that was intended to get this code to work with Xerces 1.3.1.
    The code still doesn't work with 1.3.1. Xerces 1.3.1 has known
    bugs which cause it to return "", instead of null, when a namespace
    is not specified for an element (or an attribute). This change to
    the code caused the client to accept a fault coming back from the
    server, but did nothing to address the reason for the fault. The
    reason the server threw the fault to begin with is because Xerces
    wasn't handling namespaces properly. Once the fault was accepted, you
    would see its content, which was usually something like: Unable to resolve
    namespaceURI for 'ns2'. Since both the non-acceptance of the fault,
    and the cause of the fault in the first place, are related to the same
    Xerces bug(s), if we are going to do a workaround to enable this code
    to work with Xerces 1.3.1, we need to do it everywhere; there are 9
    places where we call getNamespaceURI(...). The code works with a nightly
    build of Xerces (since they fixed the bug), so there is no reason to
    keep this change in there. I posted a message asking if anybody actually has
    Xerces 1.3.1 working with any version of Apache SOAP v2.1 or higher
    (nightly builds included), and only one person responded that he does.
    After some more checking, it was determined that a different
    JAXP-compliant parser was actually being used. So, I can't find anybody
    who actually has Xerces v1.3.1 and Apache SOAP working together, on both
    the client and the server. If somebody can show that that patch really
    let them get the two working, then we can address it further.
  
  Revision  Changes    Path
  1.8       +0 -1      xml-soap/java/src/org/apache/soap/Fault.java
  
  Index: Fault.java
  ===================================================================
  RCS file: /home/cvs/xml-soap/java/src/org/apache/soap/Fault.java,v
  retrieving revision 1.7
  retrieving revision 1.8
  diff -u -r1.7 -r1.8
  --- Fault.java	2001/04/10 22:36:16	1.7
  +++ Fault.java	2001/05/22 21:59:16	1.8
  @@ -286,7 +286,6 @@
   
           // SOAP-ENV namespace is ok, as is no namespace at all.
           if (namespaceURI == null
  -            || namespaceURI.length() == 0 
               || namespaceURI.equals(Constants.NS_URI_SOAP_ENV))
           {
             if (localPart.equals(Constants.ELEM_FAULT_CODE))