[jira] [Updated] (HADOOP-6490) Path.normalize should use StringUtils.replace in favor of String.replace

["Harsh J (Updated) (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/HADOOP-6490?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Harsh J updated HADOOP-6490:
----------------------------

    Target Version/s: 0.23.1

This is a trivial fix that can go to 0.23.1 as well. Saves one call in an object that matters. Will backport shortly.
                
> Path.normalize should use StringUtils.replace in favor of String.replace
> ------------------------------------------------------------------------
>
>                 Key: HADOOP-6490
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6490
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: fs
>    Affects Versions: 0.20.1
>            Reporter: Zheng Shao
>            Assignee: Uma Maheswara Rao G
>            Priority: Minor
>              Labels: newbie
>             Fix For: 0.24.0
>
>         Attachments: HADOOP-6490.patch
>
>
> in our environment, we are seeing that the JobClient is going out of memory because Path.normalizePath(String) is called several tens of thousands of times, and each time it calls "String.replace" twice.
> java.lang.String.replace compiles a regex to do the job which is very costly.
> We should use org.apache.commons.lang.StringUtils.replace which is much faster and consumes almost no extra memory.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira