You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@falcon.apache.org by "Arpit Gupta (JIRA)" <ji...@apache.org> on 2013/11/08 03:18:18 UTC

[jira] [Comment Edited] (FALCON-165) simplify packaging to create one package instead of client, falcon and prism packages

    [ https://issues.apache.org/jira/browse/FALCON-165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13816926#comment-13816926 ] 

Arpit Gupta edited comment on FALCON-165 at 11/8/13 2:17 AM:
-------------------------------------------------------------

Hmm dont know much about rat.. but falcon.embeddedmq.data property existed before FALCON-162. I just changed what was the value.

It used to be

{code}
-Dfalcon.embeddedmq.data=${BASEDIR}/logs/data
{code}

and after the patch it is

{code}
-Dfalcon.embeddedmq.data=$FALCON_DATA_DIR
{code}


In all we are setting the following

{code}
-Dfalcon.log.dir=$FALCON_LOG_DIR -Dfalcon.embeddedmq.data=$FALCON_DATA_DIR -Dfalcon.home=${FALCON_HOME_DIR} -Dconfig.location=$FALCON_CONF -Dfalcon.app.type=$APP_TYPE
{code}

If you call bin/service-start.sh it will set the correct defaults. 

Can we add something like to the pom?

{code}
<argLine>-Dfalcon.log.dir=target/logs -Dfalcon.embeddedmq.data=target/data</argLine>
{code}

Not a maven guru so will try this out and see. I am curious that only these 2 cause issues and not the others.



was (Author: arpitgupta):
Hmm dont know much about rat.. but falcon.embeddedmq.data property existed before FALCON-162. I just changed what was the value.

It used to be

{code}
-Dfalcon.embeddedmq.data=${BASEDIR}/logs/data
{code}

and after the patch it is

{code}
-Dfalcon.embeddedmq.data=$FALCON_DATA_DIR
{code}


In all we are setting the following

{code}
-Dfalcon.log.dir=$FALCON_LOG_DIR -Dfalcon.embeddedmq.data=$FALCON_DATA_DIR -Dfalcon.home=${FALCON_HOME_DIR} -Dconfig.location=$FALCON_CONF -Dfalcon.app.type=$APP_TYPE
{code}

If you call bin/service-start.sh it will set the correct defaults. 

Can we add something like to the pom?

{code}
<argLine>-Dfalcon.log.dir=target/logs -Dfalcon.embeddedmq.data=target/data</argLine>
{code}

Not a maven guru so will have to 


> simplify packaging to create one package instead of client, falcon and prism packages
> -------------------------------------------------------------------------------------
>
>                 Key: FALCON-165
>                 URL: https://issues.apache.org/jira/browse/FALCON-165
>             Project: Falcon
>          Issue Type: Improvement
>    Affects Versions: 0.3
>            Reporter: Arpit Gupta
>            Assignee: Arpit Gupta
>             Fix For: 0.4
>
>         Attachments: FALCON-165-1383504173.patch, FALCON-165-1383504576.patch, FALCON-165-1383607413.patch, FALCON-165-1383669545.patch, FALCON-165-1383790699.patch, FALCON-165-1383837197.patch
>
>
> Currently we create multiple packages client, falcon server and prism server.
> Our scripts how ever already add only specific files to the class path based on what server we are running. I think we can also move to a single package.
> Introduced a new java property falcon.domain which will be set to falcon or prism based on what service is being started. 
> Thus the user can set all the various startup and run time properties for both falcon and prism in the same file and the appropriate configs will be picked up based on what service is being started. 



--
This message was sent by Atlassian JIRA
(v6.1#6144)