You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2018/06/05 00:32:08 UTC

[GitHub] john-bodley opened a new pull request #5136: [CRUD] Improving performance by disabling editing Associated Charts

john-bodley opened a new pull request #5136: [CRUD] Improving performance by disabling editing Associated Charts
URL: https://github.com/apache/incubator-superset/pull/5136
 
 
   This PR helps to improve the performance of table CRUD view by removing the `slices` (Associated Charts) column from the edit view (it's still present for show). 
   
   As the number of slices grows the performance of this page is severely impacted as FAB needs to pre-fetch all the slices which are searchable in jQuery. Further it seems having the ability to either add/remove slices associated with a datasource via the CRUD view is somewhat atypical as it could result in ill-defined charts and dangling charts respectively. 
   
   to: @graceguo-supercat @michellethomas @mistercrunch @timifasubaa 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org