You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by scottyaslan <gi...@git.apache.org> on 2016/07/14 03:48:27 UTC
[GitHub] nifi pull request #646: [NIFI-2257] refresh updateattribute processor advanc...
GitHub user scottyaslan opened a pull request:
https://github.com/apache/nifi/pull/646
[NIFI-2257] refresh updateattribute processor advanced shell
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/scottyaslan/nifi responsiveDevBranch
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/646.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #646
----
commit 767cc424475460cc72d8e680e3b227c7da6ee299
Author: Scott Aslan <ja...@hortonworks.com>
Date: 2016-07-14T03:44:07Z
[NIFI-2257] refresh updateattribute processor advanced shell
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #646: [NIFI-2257] refresh updateattribute processor advanced shel...
Posted by mcgilman <gi...@git.apache.org>.
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/646
Reviewing...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request #646: [NIFI-2257] refresh updateattribute processor advanc...
Posted by mcgilman <gi...@git.apache.org>.
Github user mcgilman commented on a diff in the pull request:
https://github.com/apache/nifi/pull/646#discussion_r71017973
--- Diff: nifi-nar-bundles/nifi-update-attribute-bundle/nifi-update-attribute-ui/src/main/webapp/js/application.js ---
@@ -1598,9 +1635,9 @@ var ua = {
// create the editor
editor = $('<div></div>').addClass(editorClass).appendTo(wrapper).nfeditor({
languageId: languageId,
- width: (cellNode.width() - 5) + 'px',
+ width: '250px',
--- End diff --
I think we want to retain the previous behavior where the editor is the width of the entire cell when it's opened.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #646: [NIFI-2257] [NIFI-2294] [NIFI-2287] [NIFI-2270] refresh upd...
Posted by mcgilman <gi...@git.apache.org>.
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/646
Looks great @scottyaslan! This has been merged to master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request #646: [NIFI-2257] [NIFI-2294] [NIFI-2287] [NIFI-2270] refr...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/nifi/pull/646
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---