You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/12/13 12:50:23 UTC
[GitHub] [airflow] JCoder01 opened a new issue #13044: Task Group: Node order changes after collapse
JCoder01 opened a new issue #13044:
URL: https://github.com/apache/airflow/issues/13044
**Apache Airflow version**: 2.0.0rc1
**Kubernetes version (if you are using kubernetes)** (use `kubectl version`):
**Environment**:
- **Cloud provider or hardware configuration**:
- **OS** (e.g. from /etc/os-release):
- **Kernel** (e.g. `uname -a`):
- **Install tools**:
- **Others**:
**What happened**:
The order of the nodes changes when expanding and collapsing task groups:
Before:
After expanding task group and collapsing:
**What you expected to happen**:
node order to be consistent
**How to reproduce it**:
Create a DAG with multiple task groups.
expand the top group
collapse the top group
observe is is now at the end.
**Anything else we need to know**:
happens every time.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on issue #13044: Task Group: Node order changes after collapse
Posted by GitBox <gi...@apache.org>.
ashb commented on issue #13044:
URL: https://github.com/apache/airflow/issues/13044#issuecomment-745398784
I wonder if I don't see it cos I use Firefox
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] turbaszek commented on issue #13044: Task Group: Node order changes after collapse
Posted by GitBox <gi...@apache.org>.
turbaszek commented on issue #13044:
URL: https://github.com/apache/airflow/issues/13044#issuecomment-744017253
CC @yuqian90
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] yuqian90 commented on issue #13044: Task Group: Node order changes after collapse
Posted by GitBox <gi...@apache.org>.
yuqian90 commented on issue #13044:
URL: https://github.com/apache/airflow/issues/13044#issuecomment-744114254
> @turbaszek Yeah, there is nothing wrong with the functionality. It's just a tad annoying when things move around.
In fact, this isn't an issue for ``TaskGroup`` specifically. Even before ``TaskGroup`` was introduced, simply refreshing the page can sometimes render the Graph View differently causing the nodes to shuffle around.
I can understand the pain. However, this issue needs to be addressed in the dependent package Dagre. I think this is the open issue upstream: https://github.com/dagrejs/dagre/issues/189
Unfortunately it doesn't look like they are addressing it any time soon. Hopefully someone can come up with a workaround.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] eladkal commented on issue #13044: Task Group: Node order changes after collapse
Posted by GitBox <gi...@apache.org>.
eladkal commented on issue #13044:
URL: https://github.com/apache/airflow/issues/13044#issuecomment-746058968
I was able to reproduce using the `example_task_group` DAG :
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on issue #13044: Task Group: Node order changes after collapse
Posted by GitBox <gi...@apache.org>.
kaxil commented on issue #13044:
URL: https://github.com/apache/airflow/issues/13044#issuecomment-865938317
@bbovenzi Can you take a look at this one when you have time please
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] JCoder01 commented on issue #13044: Task Group: Node order changes after collapse
Posted by GitBox <gi...@apache.org>.
JCoder01 commented on issue #13044:
URL: https://github.com/apache/airflow/issues/13044#issuecomment-745394219
@ashb Just installed RC3 and see the same. The behavior is evident on that example_task_group dag.
Before
After
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on issue #13044: Task Group: Node order changes after collapse
Posted by GitBox <gi...@apache.org>.
ashb commented on issue #13044:
URL: https://github.com/apache/airflow/issues/13044#issuecomment-745211259
Could some test this on Rc3 -- I don't see it there.
If you do see it, please give me a reproduction test case.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] JCoder01 commented on issue #13044: Task Group: Node order changes after collapse
Posted by GitBox <gi...@apache.org>.
JCoder01 commented on issue #13044:
URL: https://github.com/apache/airflow/issues/13044#issuecomment-744020497
@turbaszek Yeah, there is nothing wrong with the functionality. It's just a tad annoying when things move around.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] JCoder01 commented on issue #13044: Task Group: Node order changes after collapse
Posted by GitBox <gi...@apache.org>.
JCoder01 commented on issue #13044:
URL: https://github.com/apache/airflow/issues/13044#issuecomment-745412298
I don't know, I tried Firefox on both windows and linux and the same thing happens.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] yuqian90 commented on issue #13044: Task Group: Node order changes after collapse
Posted by GitBox <gi...@apache.org>.
yuqian90 commented on issue #13044:
URL: https://github.com/apache/airflow/issues/13044#issuecomment-869084448
Hi @bbovenzi , just curious, what graphing library are we switching to in AIP-38? I think it makes sense to start thinking about how to implement Graph View and Tree View using that new library.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] bbovenzi commented on issue #13044: Task Group: Node order changes after collapse
Posted by GitBox <gi...@apache.org>.
bbovenzi commented on issue #13044:
URL: https://github.com/apache/airflow/issues/13044#issuecomment-869048497
dagre still has not been updated. If someone wants to fork that library or add logic to remember the order, feel free to open a PR. But I will not be focusing on this as we will use a different graphing library in AIP-38.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] turbaszek commented on issue #13044: Task Group: Node order changes after collapse
Posted by GitBox <gi...@apache.org>.
turbaszek commented on issue #13044:
URL: https://github.com/apache/airflow/issues/13044#issuecomment-744017369
Thanks @JCoder01, as I understand this is not a "real bug" but just an unpleasant UX, right?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] bbovenzi commented on issue #13044: Task Group: Node order changes after collapse
Posted by GitBox <gi...@apache.org>.
bbovenzi commented on issue #13044:
URL: https://github.com/apache/airflow/issues/13044#issuecomment-870648142
@yuqian90 I'm still looking into it, so I'm open to suggestions. We can certainly bring those updates into the current UI when it's well tested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org