You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@knox.apache.org by GitBox <gi...@apache.org> on 2020/03/04 13:23:55 UTC

[GitHub] [knox] stoty opened a new pull request #278: KNOX-2262 Accessing hbase logs through knox exposes hbase endpoint ur…

stoty opened a new pull request #278: KNOX-2262 Accessing hbase logs through knox exposes hbase endpoint ur…
URL: https://github.com/apache/knox/pull/278
 
 
   …l instead of routing through knox
   
   * Add redirect filter for HBase webu /logs location
   * Perform Request URL trailing space correction in HBase dispatch
   * Remove deprecation from HBase dispatch
   * Add HA dispatch for HBase ( identical functionality to non-HA)
   * Refer HA dispatch in service.xml
   * Refactor common dispatch logic into HBaseRequestUtil.java
   
   ## How was this patch tested?
   
   Deployed patched Knox on a live HBase cluster
   checked that I can access the directories, and the files in the subdirectories
   checked that the links and redirects all go to Knox proxied URLs

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [knox] risdenk commented on issue #278: KNOX-2262 Accessing hbase logs through knox exposes hbase endpoint ur…

Posted by GitBox <gi...@apache.org>.
risdenk commented on issue #278: KNOX-2262 Accessing hbase logs through knox exposes hbase endpoint ur…
URL: https://github.com/apache/knox/pull/278#issuecomment-608009585
 
 
   Sorry @stoty this definitely fell off my radar after I initially looked at it.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [knox] risdenk commented on issue #278: KNOX-2262 Accessing hbase logs through knox exposes hbase endpoint ur…

Posted by GitBox <gi...@apache.org>.
risdenk commented on issue #278: KNOX-2262 Accessing hbase logs through knox exposes hbase endpoint ur…
URL: https://github.com/apache/knox/pull/278#issuecomment-608443531
 
 
   Thanks @stoty I made some slight changes locally, but planning to commit this today. 
   
   I created HBaseUIDispatch and HBaseUIHADispatch so we can avoid the deprecated HBaseDispatch. I made the newer UI dispatches not use the decodeUrl since that isn't needed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [knox] stoty commented on issue #278: KNOX-2262 Accessing hbase logs through knox exposes hbase endpoint ur…

Posted by GitBox <gi...@apache.org>.
stoty commented on issue #278: KNOX-2262 Accessing hbase logs through knox exposes hbase endpoint ur…
URL: https://github.com/apache/knox/pull/278#issuecomment-608457771
 
 
   Thanks for the review and cleanup @risdenk 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [knox] asfgit closed pull request #278: KNOX-2262 Accessing hbase logs through knox exposes hbase endpoint ur…

Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #278: KNOX-2262 Accessing hbase logs through knox exposes hbase endpoint ur…
URL: https://github.com/apache/knox/pull/278
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [knox] stoty commented on issue #278: KNOX-2262 Accessing hbase logs through knox exposes hbase endpoint ur…

Posted by GitBox <gi...@apache.org>.
stoty commented on issue #278: KNOX-2262 Accessing hbase logs through knox exposes hbase endpoint ur…
URL: https://github.com/apache/knox/pull/278#issuecomment-608021693
 
 
   Thanks for the review @risdenk, it happens.
   
   Actually I don't think that the decodeUrl() method does anything useful (anymore) either, considering that a lot of folks were running without the old dispatch, since it didn't apply to the HA setup.
   
   However that was not a can of worms I wanted to open, so I left it alone.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services