You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "Kiril Raychev (JIRA)" <ji...@apache.org> on 2012/06/14 14:09:42 UTC
[jira] [Commented] (THRIFT-1608) Allow servlet to be supplied
TProcessor and TProtocolFactory after the init() method has finished
[ https://issues.apache.org/jira/browse/THRIFT-1608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13294981#comment-13294981 ]
Kiril Raychev commented on THRIFT-1608:
---------------------------------------
Just reminding you about this. Please give suggestions if this is ok, and if I can make it better somehow.
> Allow servlet to be supplied TProcessor and TProtocolFactory after the init() method has finished
> -------------------------------------------------------------------------------------------------
>
> Key: THRIFT-1608
> URL: https://issues.apache.org/jira/browse/THRIFT-1608
> Project: Thrift
> Issue Type: Improvement
> Components: Java - Library
> Environment: any
> Reporter: Kiril Raychev
> Attachments: TExtensibleServlet.java, thrift-1608-textensibleservlet.path
>
>
> Servlets are generally considered ready to use after the init() method has finished. That is, they are open for configuration before that. TServlet does not follow that - it requires TProcessor and TProtocolFactory as constructor args.
> I think it will be better if if you could use the ServletContext to get the necessary processor and factories. Those objects could be set in the context, or it may just be more convenient not to supply them at the constructor.
> I have attached a modified version of the TServlet, with a new name. It uses abstract methods to get the required processor and factories. I don't think it can be added cleanly to the existing TServlet, so it should be a separate class.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira