You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by Steven Gill <st...@gmail.com> on 2017/10/06 22:45:12 UTC

[VOTE] Tools Release

Please review and vote on this Tools Release
by replying to this email (and keep discussion on the DISCUSS thread)

Release issue: https://issues.apache.org/jira/browse/CB-13380

Tools have been published to
dist/dev:https://dist.apache.org/repos/dist/dev/cordova/CB-13380/

The packages were published from their corresponding git tags:

    cordova-js: 4.2.2 (f03c7971c2)
    cordova-lib: 7.1.0 (1a8c8abb77)
    cordova-plugman: 1.5.1 (128d95269f)
    cordova-cli: 7.1.0 (cc5cb8a6e8)
    cordova-fetch: 1.2.0 (522ed6593e)
    cordova-common: 2.1.1 (e76dd52f67)
    cordova-node-xcode: 1.0.0 (9345e5ed03)

Upon a successful vote I will upload the archives to dist/, publish
them to npm, and post the corresponding blog post.

Voting guidelines:
https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md

Voting will go on for a minimum of 48 hours.

I vote +1:
* Ran coho audit-license-headers over the relevant repos
* Ran coho check-license to ensure all dependencies and
subdependencies have Apache-compatible licenses
* Ran npm test in each repo
* Did basic hello world test, adding/removing platforms/plugins

Re: [VOTE] Tools Release

Posted by Steven Gill <st...@gmail.com>.
The vote has now closed. The results are:

Positive Binding Votes: (# of PMC members that +1'ed)

Steve Gill
Audrey So
Jesse MacFadyen

The vote has passed.


On Mon, Oct 9, 2017 at 3:35 PM, Jesse <pu...@gmail.com> wrote:

> I vote +1:
> * Coho verify-archives
> * Ran npm test on all the repos (all passing except for 1 timeout in
> fetch),
> * Built an app (added+rm ios)
>
> In order to actually test the versions of all packages listed in here, I
> had to run the following to checkout the correct version.  Use if you like.
>
> cd cordova-js
> git checkout f03c7971c2
> cd ../cordova-lib
> git checkout 1a8c8abb77
> cd ../cordova-plugman
> git checkout 128d95269f
> cd ../cordova-cli
> git checkout cc5cb8a6e8
> cd ../cordova-fetch
> git checkout 522ed6593e
> cd ../cordova-common
> git checkout e76dd52f67
> cd ../cordova-node-xcode
> git checkout 9345e5ed03
> cd ..
> coho npm-link
>
>
>
> @purplecabbage
> risingj.com
>
> On Mon, Oct 9, 2017 at 2:32 PM, Audrey So <au...@adobe.com.invalid> wrote:
>
> > I vote +1:
> > * Ran npm test on all the repos (all passing),
> > * Built a hello world app (added/ rm platform and plugin)
> > * Coho audit-license-headers
> > * Coho check-license
> >
> >
> >
> > — Audrey
> >
> > On 10/6/17, 3:45 PM, "Steven Gill" <st...@gmail.com> wrote:
> >
> > >Please review and vote on this Tools Release
> > >by replying to this email (and keep discussion on the DISCUSS thread)
> > >
> > >Release issue: https://na01.safelinks.protection.outlook.com/?url=
> > https%3A%2F%2Fissues.apache.org%2Fjira%2Fbrowse%2FCB-
> > 13380&data=02%7C01%7C%7C52ccfe40bad84d677a8108d50d0bf769%
> > 7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636429267400494850&sdata=
> > Bukz7zoMaTLzvta1cPd54irhlXO6boTgTQDh8l4hCaE%3D&reserved=0
> > >
> > >Tools have been published to
> > >dist/dev:https://dist.apache.org/repos/dist/dev/cordova/CB-13380/
> > >
> > >The packages were published from their corresponding git tags:
> > >
> > >    cordova-js: 4.2.2 (f03c7971c2)
> > >    cordova-lib: 7.1.0 (1a8c8abb77)
> > >    cordova-plugman: 1.5.1 (128d95269f)
> > >    cordova-cli: 7.1.0 (cc5cb8a6e8)
> > >    cordova-fetch: 1.2.0 (522ed6593e)
> > >    cordova-common: 2.1.1 (e76dd52f67)
> > >    cordova-node-xcode: 1.0.0 (9345e5ed03)
> > >
> > >Upon a successful vote I will upload the archives to dist/, publish
> > >them to npm, and post the corresponding blog post.
> > >
> > >Voting guidelines:
> > >https://na01.safelinks.protection.outlook.com/?url=
> > https%3A%2F%2Fgithub.com%2Fapache%2Fcordova-coho%2Fblob%2Fmaster%2Fdocs%
> > 2Frelease-voting.md&data=02%7C01%7C%7C52ccfe40bad84d677a8108d50d0bf769%
> > 7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636429267400494850&sdata=
> > SBuZWjiU7MyqZU2A64FKHHyTsbEd%2BrzYJIBitoJRNbY%3D&reserved=0
> > >
> > >Voting will go on for a minimum of 48 hours.
> > >
> > >I vote +1:
> > >* Ran coho audit-license-headers over the relevant repos
> > >* Ran coho check-license to ensure all dependencies and
> > >subdependencies have Apache-compatible licenses
> > >* Ran npm test in each repo
> > >* Did basic hello world test, adding/removing platforms/plugins
> >
>

Re: [VOTE] Tools Release

Posted by Jesse <pu...@gmail.com>.
I vote +1:
* Coho verify-archives
* Ran npm test on all the repos (all passing except for 1 timeout in fetch),
* Built an app (added+rm ios)

In order to actually test the versions of all packages listed in here, I
had to run the following to checkout the correct version.  Use if you like.

cd cordova-js
git checkout f03c7971c2
cd ../cordova-lib
git checkout 1a8c8abb77
cd ../cordova-plugman
git checkout 128d95269f
cd ../cordova-cli
git checkout cc5cb8a6e8
cd ../cordova-fetch
git checkout 522ed6593e
cd ../cordova-common
git checkout e76dd52f67
cd ../cordova-node-xcode
git checkout 9345e5ed03
cd ..
coho npm-link



@purplecabbage
risingj.com

On Mon, Oct 9, 2017 at 2:32 PM, Audrey So <au...@adobe.com.invalid> wrote:

> I vote +1:
> * Ran npm test on all the repos (all passing),
> * Built a hello world app (added/ rm platform and plugin)
> * Coho audit-license-headers
> * Coho check-license
>
>
>
> — Audrey
>
> On 10/6/17, 3:45 PM, "Steven Gill" <st...@gmail.com> wrote:
>
> >Please review and vote on this Tools Release
> >by replying to this email (and keep discussion on the DISCUSS thread)
> >
> >Release issue: https://na01.safelinks.protection.outlook.com/?url=
> https%3A%2F%2Fissues.apache.org%2Fjira%2Fbrowse%2FCB-
> 13380&data=02%7C01%7C%7C52ccfe40bad84d677a8108d50d0bf769%
> 7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636429267400494850&sdata=
> Bukz7zoMaTLzvta1cPd54irhlXO6boTgTQDh8l4hCaE%3D&reserved=0
> >
> >Tools have been published to
> >dist/dev:https://dist.apache.org/repos/dist/dev/cordova/CB-13380/
> >
> >The packages were published from their corresponding git tags:
> >
> >    cordova-js: 4.2.2 (f03c7971c2)
> >    cordova-lib: 7.1.0 (1a8c8abb77)
> >    cordova-plugman: 1.5.1 (128d95269f)
> >    cordova-cli: 7.1.0 (cc5cb8a6e8)
> >    cordova-fetch: 1.2.0 (522ed6593e)
> >    cordova-common: 2.1.1 (e76dd52f67)
> >    cordova-node-xcode: 1.0.0 (9345e5ed03)
> >
> >Upon a successful vote I will upload the archives to dist/, publish
> >them to npm, and post the corresponding blog post.
> >
> >Voting guidelines:
> >https://na01.safelinks.protection.outlook.com/?url=
> https%3A%2F%2Fgithub.com%2Fapache%2Fcordova-coho%2Fblob%2Fmaster%2Fdocs%
> 2Frelease-voting.md&data=02%7C01%7C%7C52ccfe40bad84d677a8108d50d0bf769%
> 7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636429267400494850&sdata=
> SBuZWjiU7MyqZU2A64FKHHyTsbEd%2BrzYJIBitoJRNbY%3D&reserved=0
> >
> >Voting will go on for a minimum of 48 hours.
> >
> >I vote +1:
> >* Ran coho audit-license-headers over the relevant repos
> >* Ran coho check-license to ensure all dependencies and
> >subdependencies have Apache-compatible licenses
> >* Ran npm test in each repo
> >* Did basic hello world test, adding/removing platforms/plugins
>

Re: [VOTE] Tools Release

Posted by Audrey So <au...@adobe.com.INVALID>.
I vote +1:
* Ran npm test on all the repos (all passing), 
* Built a hello world app (added/ rm platform and plugin)
* Coho audit-license-headers
* Coho check-license



— Audrey

On 10/6/17, 3:45 PM, "Steven Gill" <st...@gmail.com> wrote:

>Please review and vote on this Tools Release
>by replying to this email (and keep discussion on the DISCUSS thread)
>
>Release issue: https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fissues.apache.org%2Fjira%2Fbrowse%2FCB-13380&data=02%7C01%7C%7C52ccfe40bad84d677a8108d50d0bf769%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636429267400494850&sdata=Bukz7zoMaTLzvta1cPd54irhlXO6boTgTQDh8l4hCaE%3D&reserved=0
>
>Tools have been published to
>dist/dev:https://dist.apache.org/repos/dist/dev/cordova/CB-13380/
>
>The packages were published from their corresponding git tags:
>
>    cordova-js: 4.2.2 (f03c7971c2)
>    cordova-lib: 7.1.0 (1a8c8abb77)
>    cordova-plugman: 1.5.1 (128d95269f)
>    cordova-cli: 7.1.0 (cc5cb8a6e8)
>    cordova-fetch: 1.2.0 (522ed6593e)
>    cordova-common: 2.1.1 (e76dd52f67)
>    cordova-node-xcode: 1.0.0 (9345e5ed03)
>
>Upon a successful vote I will upload the archives to dist/, publish
>them to npm, and post the corresponding blog post.
>
>Voting guidelines:
>https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fapache%2Fcordova-coho%2Fblob%2Fmaster%2Fdocs%2Frelease-voting.md&data=02%7C01%7C%7C52ccfe40bad84d677a8108d50d0bf769%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636429267400494850&sdata=SBuZWjiU7MyqZU2A64FKHHyTsbEd%2BrzYJIBitoJRNbY%3D&reserved=0
>
>Voting will go on for a minimum of 48 hours.
>
>I vote +1:
>* Ran coho audit-license-headers over the relevant repos
>* Ran coho check-license to ensure all dependencies and
>subdependencies have Apache-compatible licenses
>* Ran npm test in each repo
>* Did basic hello world test, adding/removing platforms/plugins