You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/09/13 08:13:58 UTC
[GitHub] [spark] LuciferYang opened a new pull request #33977: [SPARK-36737][BUILD][CORE][SQL][SS] Upgrade Apache commons-io to 2.11.0 and revert change of SPARK-36737
LuciferYang opened a new pull request #33977:
URL: https://github.com/apache/spark/pull/33977
### What changes were proposed in this pull request?
SPARK-36737 change to use `JavaUtils. closeQuietly` instead of `IOUtils.closeQuietly`, but there is slightly different from the 2 methods in default behavior: swallowing IOException is same, but the former logs it as ERROR while the latter doesn't log by default.
`Apache commons-io` community decided to retain the `IOUtils.closeQuietly` method in the [new version](https://github.com/apache/commons-io/blob/75f20dca72656225d0dc8e7c982e40caa9277d42/src/main/java/org/apache/commons/io/IOUtils.java#L465-L467) and removed deprecated annotation, the change has been released in version 2.11.0.
So the change of this pr is to upgrade `Apache commons-io` to 2.11.0 and revert change of SPARK-36737 to maintain original behavior(don't print error log).
### Why are the changes needed?
1. Upgrade `Apache commons-io` to 2.11.0 to use non-deprecated `closeQuietly` API
2. Revert change of SPARK-36737 to maintain original `IOUtils.closeQuietly` API behavior(don't print error log).
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
Pass the Jenkins or GitHub Action
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HeartSaVioR edited a comment on pull request #33977: [SPARK-36737][BUILD][CORE][SQL][SS] Upgrade Apache commons-io to 2.11.0 and revert change of SPARK-36456
Posted by GitBox <gi...@apache.org>.
HeartSaVioR edited a comment on pull request #33977:
URL: https://github.com/apache/spark/pull/33977#issuecomment-919093194
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on pull request #33977: [SPARK-36737][BUILD][CORE][SQL][SS] Upgrade Apache commons-io to 2.11.0 and revert change of SPARK-36456
Posted by GitBox <gi...@apache.org>.
LuciferYang commented on pull request #33977:
URL: https://github.com/apache/spark/pull/33977#issuecomment-918751290
> IOUtils.closeQuietly can also receive consumer to define the behavior around IOException. (That said, JavaUtils.closeQuietly can be reimplemented as well leveraging IOUtils.closeQuietly) The default behavior is no-op (so no log message).
Yes, I was just thinking about this. Should we define a `consumer` for logging, and use `IOUtils.closeQuietly(Closeable, Consumer<IOException>)` API where `JavaUtils.closeQuietly` is used
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang edited a comment on pull request #33977: [SPARK-36737][BUILD][CORE][SQL][SS] Upgrade Apache commons-io to 2.11.0 and revert change of SPARK-36456
Posted by GitBox <gi...@apache.org>.
LuciferYang edited a comment on pull request #33977:
URL: https://github.com/apache/spark/pull/33977#issuecomment-918751290
> IOUtils.closeQuietly can also receive consumer to define the behavior around IOException. (That said, JavaUtils.closeQuietly can be reimplemented as well leveraging IOUtils.closeQuietly) The default behavior is no-op (so no log message).
I was just thinking about this. Should we define a `consumer` for logging, and use `IOUtils.closeQuietly(Closeable, Consumer<IOException>)` API where `JavaUtils.closeQuietly` is used
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33977: [SPARK-36737][BUILD][CORE][SQL][SS] Upgrade Apache commons-io to 2.11.0 and revert change of SPARK-36456
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33977:
URL: https://github.com/apache/spark/pull/33977#issuecomment-918014439
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/47696/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33977: [SPARK-36737][BUILD][CORE][SQL][SS] Upgrade Apache commons-io to 2.11.0 and revert change of SPARK-36456
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33977:
URL: https://github.com/apache/spark/pull/33977#issuecomment-917973795
**[Test build #143194 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143194/testReport)** for PR 33977 at commit [`90a2544`](https://github.com/apache/spark/commit/90a254462e726eaaf6204f2db69fee7387ed7ada).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #33977: [SPARK-36737][BUILD][CORE][SQL][SS] Upgrade Apache commons-io to 2.11.0 and revert change of SPARK-36456
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33977:
URL: https://github.com/apache/spark/pull/33977#issuecomment-918016404
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/47696/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] mridulm commented on pull request #33977: [SPARK-36737][BUILD][CORE][SQL][SS] Upgrade Apache commons-io to 2.11.0 and revert change of SPARK-36456
Posted by GitBox <gi...@apache.org>.
mridulm commented on pull request #33977:
URL: https://github.com/apache/spark/pull/33977#issuecomment-918427668
Do we want to preserve this behavior (of suppressing log message) and rely on commons for something `JavaUtils` already does ? The intent of `closeQuietly` is more to ensure close does not throw exceptions - the lack of log message was behavior of commons - or is that a requirement as well ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33977: [SPARK-36737][BUILD][CORE][SQL][SS] Upgrade Apache commons-io to 2.11.0 and revert change of SPARK-36456
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33977:
URL: https://github.com/apache/spark/pull/33977#issuecomment-918008049
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/47696/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HeartSaVioR commented on pull request #33977: [SPARK-36737][BUILD][CORE][SQL][SS] Upgrade Apache commons-io to 2.11.0 and revert change of SPARK-36456
Posted by GitBox <gi...@apache.org>.
HeartSaVioR commented on pull request #33977:
URL: https://github.com/apache/spark/pull/33977#issuecomment-919093194
Yeah that's one of idea on reimplementing JavaUtils.closeQuietly, but I agree it's orthogonal to this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang edited a comment on pull request #33977: [SPARK-36737][BUILD][CORE][SQL][SS] Upgrade Apache commons-io to 2.11.0 and revert change of SPARK-36456
Posted by GitBox <gi...@apache.org>.
LuciferYang edited a comment on pull request #33977:
URL: https://github.com/apache/spark/pull/33977#issuecomment-918751290
> IOUtils.closeQuietly can also receive consumer to define the behavior around IOException. (That said, JavaUtils.closeQuietly can be reimplemented as well leveraging IOUtils.closeQuietly) The default behavior is no-op (so no log message).
I was just thinking about this. Should we define a `consumer` for logging, and use `IOUtils.closeQuietly(Closeable, Consumer<IOException>)` API where `JavaUtils.closeQuietly` is used. But it's not related to the current pr
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang edited a comment on pull request #33977: [SPARK-36737][BUILD][CORE][SQL][SS] Upgrade Apache commons-io to 2.11.0 and revert change of SPARK-36456
Posted by GitBox <gi...@apache.org>.
LuciferYang edited a comment on pull request #33977:
URL: https://github.com/apache/spark/pull/33977#issuecomment-917959287
@HeartSaVioR It seems that there is no transitive dependency change, all maven dependency scope of `Apache commons-io` are test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #33977: [SPARK-36737][BUILD][CORE][SQL][SS] Upgrade Apache commons-io to 2.11.0 and revert change of SPARK-36456
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33977:
URL: https://github.com/apache/spark/pull/33977#issuecomment-918108025
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/143194/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on pull request #33977: [SPARK-36737][BUILD][CORE][SQL][SS] Upgrade Apache commons-io to 2.11.0 and revert change of SPARK-36456
Posted by GitBox <gi...@apache.org>.
LuciferYang commented on pull request #33977:
URL: https://github.com/apache/spark/pull/33977#issuecomment-919111416
thanks all ~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HeartSaVioR commented on pull request #33977: [SPARK-36737][BUILD][CORE][SQL][SS] Upgrade Apache commons-io to 2.11.0 and revert change of SPARK-36456
Posted by GitBox <gi...@apache.org>.
HeartSaVioR commented on pull request #33977:
URL: https://github.com/apache/spark/pull/33977#issuecomment-919093724
Thanks! Merging to master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #33977: [SPARK-36737][BUILD][CORE][SQL][SS] Upgrade Apache commons-io to 2.11.0 and revert change of SPARK-36456
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #33977:
URL: https://github.com/apache/spark/pull/33977#issuecomment-918016404
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/47696/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on pull request #33977: [SPARK-36737][BUILD][CORE][SQL][SS] Upgrade Apache commons-io to 2.11.0 and revert change of SPARK-36456
Posted by GitBox <gi...@apache.org>.
LuciferYang commented on pull request #33977:
URL: https://github.com/apache/spark/pull/33977#issuecomment-917952246
cc @HeartSaVioR @dongjoon-hyun this pr merge upgrade ·commons-io· and revert change of SPARK-36456 in one, If need to split it into 2 pr, please let me know.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HeartSaVioR closed pull request #33977: [SPARK-36737][BUILD][CORE][SQL][SS] Upgrade Apache commons-io to 2.11.0 and revert change of SPARK-36456
Posted by GitBox <gi...@apache.org>.
HeartSaVioR closed pull request #33977:
URL: https://github.com/apache/spark/pull/33977
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #33977: [SPARK-36737][BUILD][CORE][SQL][SS] Upgrade Apache commons-io to 2.11.0 and revert change of SPARK-36456
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #33977:
URL: https://github.com/apache/spark/pull/33977#issuecomment-918108025
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/143194/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33977: [SPARK-36737][BUILD][CORE][SQL][SS] Upgrade Apache commons-io to 2.11.0 and revert change of SPARK-36456
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33977:
URL: https://github.com/apache/spark/pull/33977#issuecomment-918095555
**[Test build #143194 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143194/testReport)** for PR 33977 at commit [`90a2544`](https://github.com/apache/spark/commit/90a254462e726eaaf6204f2db69fee7387ed7ada).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] mridulm commented on pull request #33977: [SPARK-36737][BUILD][CORE][SQL][SS] Upgrade Apache commons-io to 2.11.0 and revert change of SPARK-36456
Posted by GitBox <gi...@apache.org>.
mridulm commented on pull request #33977:
URL: https://github.com/apache/spark/pull/33977#issuecomment-918793111
I like the consumer idea - with a default noop consumer which will ignore the message for the case @HeartSaVioR mentioned (when we truely dont care if exception is thrown).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HeartSaVioR commented on pull request #33977: [SPARK-36737][BUILD][CORE][SQL][SS] Upgrade Apache commons-io to 2.11.0 and revert change of SPARK-36456
Posted by GitBox <gi...@apache.org>.
HeartSaVioR commented on pull request #33977:
URL: https://github.com/apache/spark/pull/33977#issuecomment-918666240
I can't say for every places we use, but if I understand correctly, in HDFSBackedStateStoreProvider, we simplified the logic via allowing to close stream twice (with suppression of log message), given the fact that IOException happens with temporary file and we don't hurt anything.
SPARK-36456 seemed to actually deal with deprecation warning message, which means the behavioral difference between IOUtils.closeQuietly and JavaUtils.closeQuietly is an unintentional change. If we identify somewhere we use IOUtils.closeQuietly which is better to log swallowed IOException, we should have a separate PR to change there to JavaUtils.closeQuietly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HeartSaVioR commented on pull request #33977: [SPARK-36737][BUILD][CORE][SQL][SS] Upgrade Apache commons-io to 2.11.0 and revert change of SPARK-36456
Posted by GitBox <gi...@apache.org>.
HeartSaVioR commented on pull request #33977:
URL: https://github.com/apache/spark/pull/33977#issuecomment-918668142
IOUtils.closeQuietly can also receive consumer to define the behavior around IOException. The default behavior is no-op (so no log message).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang edited a comment on pull request #33977: [SPARK-36737][BUILD][CORE][SQL][SS] Upgrade Apache commons-io to 2.11.0 and revert change of SPARK-36456
Posted by GitBox <gi...@apache.org>.
LuciferYang edited a comment on pull request #33977:
URL: https://github.com/apache/spark/pull/33977#issuecomment-918751290
> IOUtils.closeQuietly can also receive consumer to define the behavior around IOException. (That said, JavaUtils.closeQuietly can be reimplemented as well leveraging IOUtils.closeQuietly) The default behavior is no-op (so no log message).
I was just thinking about this. Should we define a `consumer` for logging, and use `IOUtils.closeQuietly(Closeable, Consumer<IOException>)` API where `JavaUtils.closeQuietly` is used. Of course, this is another thing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #33977: [SPARK-36737][BUILD][CORE][SQL][SS] Upgrade Apache commons-io to 2.11.0 and revert change of SPARK-36456
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #33977:
URL: https://github.com/apache/spark/pull/33977#issuecomment-917973795
**[Test build #143194 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143194/testReport)** for PR 33977 at commit [`90a2544`](https://github.com/apache/spark/commit/90a254462e726eaaf6204f2db69fee7387ed7ada).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HeartSaVioR edited a comment on pull request #33977: [SPARK-36737][BUILD][CORE][SQL][SS] Upgrade Apache commons-io to 2.11.0 and revert change of SPARK-36456
Posted by GitBox <gi...@apache.org>.
HeartSaVioR edited a comment on pull request #33977:
URL: https://github.com/apache/spark/pull/33977#issuecomment-918668142
IOUtils.closeQuietly can also receive consumer to define the behavior around IOException. (That said, JavaUtils.closeQuietly can be reimplemented as well leveraging IOUtils.closeQuietly) The default behavior is no-op (so no log message).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on pull request #33977: [SPARK-36737][BUILD][CORE][SQL][SS] Upgrade Apache commons-io to 2.11.0 and revert change of SPARK-36456
Posted by GitBox <gi...@apache.org>.
LuciferYang commented on pull request #33977:
URL: https://github.com/apache/spark/pull/33977#issuecomment-917959287
@HeartSaVioR It seems that there is no transitive dependency, all maven dependency scope of `Apache commons-io` are test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org