[jira] [Commented] (NUTCH-2072) Deflate encoding support is broken when http.content.limit is set to -1

["Chris A. Mattmann (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/NUTCH-2072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14651277#comment-14651277 ] 

Chris A. Mattmann commented on NUTCH-2072:
------------------------------------------

Tests pass:

{noformat}

copy-generated-lib:

test:
     [echo] Testing plugin: urlnormalizer-slash
    [junit] WARNING: multiple versions of ant detected in path for junit 
    [junit]          jar:file:/usr/local/Cellar/ant/1.9.4/libexec/lib/ant.jar!/org/apache/tools/ant/Project.class
    [junit]      and jar:file:/Users/mattmann/tmp/nutch-trunk/build/test/lib/ant-1.6.5.jar!/org/apache/tools/ant/Project.class
    [junit] Running org.apache.nutch.net.urlnormalizer.slash.TestSlashURLNormalizer
    [junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 2.055 sec
    [junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 11.856 sec
    [junit] Running org.apache.nutch.tika.TestRTFParser
    [junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 1, Time elapsed: 0.125 sec
    [junit] Running org.apache.nutch.tika.TestRobotsMetaProcessor
    [junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 17.994 sec

BUILD SUCCESSFUL
Total time: 13 minutes 21 seconds
{noformat}

Committing this now. Thanks.


> Deflate encoding support is broken when http.content.limit is set to -1
> -----------------------------------------------------------------------
>
>                 Key: NUTCH-2072
>                 URL: https://issues.apache.org/jira/browse/NUTCH-2072
>             Project: Nutch
>          Issue Type: Bug
>          Components: plugin, protocol
>            Reporter: Tanguy Moal
>            Assignee: Chris A. Mattmann
>            Priority: Minor
>             Fix For: 1.11
>
>
> The method {{DeflateUtils.inflateBestEffort(byte[] in, int sizeLimit)}} is not designed to have sizeLimit set to a negative value.
> The fix can be simply to mimic what's done with gzip encoding : if {{getMaxContent() < 0}} then use {{Integer.MAX_VALUE}} for the {{sizeLimit}} argument.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)