Re: [PR] [WIP] Use checkInputDataTypes to check the parameter types of the function `to_xml` & remove _LEGACY_ERROR_TEMP_3234 [spark]

["panbingkun (via GitHub)" <gi...@apache.org>]

panbingkun commented on PR #45167:
URL: https://github.com/apache/spark/pull/45167#issuecomment-1986789521

   > @panbingkun Could fill in PR description, please. You changes are pretty useful, I believe.
   
   @MaxGekk 
   
   Okay, let me update it.
   But this PR actually did `two` aims, one of which was the `deletion` of the error classes `_LEGACY_ERROR_TEMP_3234`, which also involved another PR: https://github.com/apache/spark/pull/44665.
   Because the error classes `_LEGACY_ERROR_TEMP_3234` is only used in these two points, as follows:
   
   https://github.com/apache/spark/blob/76b1c122cb7d77e8f175b25b935b9296a669d5d8/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/csvExpressions.scala#L270
   
   https://github.com/apache/spark/blob/76b1c122cb7d77e8f175b25b935b9296a669d5d8/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/xmlExpressions.scala#L287
   
   I originally wanted to continue this PR after merging  [44665](https://github.com/apache/spark/pull/44665) into codebase (so that the error classes `_LEGACY_ERROR_TEMP_3234` could be deleted directly).
   
   If you have time, can you help me review this PR [44665](https://github.com/apache/spark/pull/44665) first?
   
   Or I can modify this PR first and temporarily `not delete` the error class `_LEGACY_ERROR_TEMP_3234`.
   
   Thank you very much! ❤️


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org