[GitHub] starpit opened a new issue #77: consider switching from request-promise to needle

[GitBox <gi...@apache.org>]

starpit opened a new issue #77: consider switching from request-promise to needle
URL: https://github.com/apache/incubator-openwhisk-client-js/issues/77
 
 
   request-promise depends on request, which is very slow to load: https://github.com/request/request/issues/2261
   
   that issue aligns with my experience.  namely, that request-promise, due to request, can take anywhere from 120-250ms to `require` on mac and linux.
   
   on windows 10, apparently due to windows defender, it can take 10 times as long! sometimes multiple seconds!
   
   an alternative is needle: https://www.npmjs.com/package/needle
   
   quick experiments show that needle indeed loads in about 1/4th the time. these numbers from macos 10.12.6, node 8.5.0: fairly stably needle loads in 30-32ms, and request-promise in 110-120ms.
   
   in more realistic scenarios, i've seen request-promise routinely take close to 300ms.
   
   the patch for this is straightforward, as needle mostly obeys the same schema as rp.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services