[GitHub] [couchdb-helm] willholley commented on a diff in pull request #106: Simplify admin hash in the secret

[GitBox <gi...@apache.org>]

willholley commented on code in PR #106:
URL: https://github.com/apache/couchdb-helm/pull/106#discussion_r1064485100


##########
couchdb/README.md:
##########
@@ -86,6 +79,7 @@ and then install the chart while overriding the `createAdminSecret` setting:
 $ helm install \
   --name my-release \
   --version=3.6.1 \

Review Comment:
   bump version here to the version supporting adminHash (3.6.5)



##########
couchdb/README.md:
##########
@@ -86,6 +79,7 @@ and then install the chart while overriding the `createAdminSecret` setting:
 $ helm install \
   --name my-release \
   --version=3.6.1 \
+  --set adminHash=true/false \

Review Comment:
   I think adminHash is the hash (`-pbkdf2-d4b887da...`) rather than `true/false`? If it's not already described, it would be useful to note / link to documentation around how to create that value from a password.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org