You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/08/03 17:34:39 UTC

[GitHub] [arrow] cpcloud commented on a change in pull request #10849: ARROW-13507: [R] LTO job on CRAN fails

cpcloud commented on a change in pull request #10849:
URL: https://github.com/apache/arrow/pull/10849#discussion_r681966121



##########
File path: r/inst/build_arrow_static.sh
##########
@@ -75,6 +79,7 @@ ${CMAKE} -DARROW_BOOST_USE_SHARED=OFF \
     -DCMAKE_EXPORT_NO_PACKAGE_REGISTRY=ON \
     -DCMAKE_FIND_PACKAGE_NO_PACKAGE_REGISTRY=ON \
     -DCMAKE_UNITY_BUILD=${CMAKE_UNITY_BUILD:-ON} \
+    -DCMAKE_INTERPROCEDURAL_OPTIMIZATION=${ARROW_LTO:-ON} \

Review comment:
       Should this be `${ARROW_LTO:-$ARROW_DEFAULT_PARAM}`? As it currently is, it looks like LTO will always be turned on.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org