You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@iggy.apache.org by "mayakerostasia (via GitHub)" <gi...@apache.org> on 2025/07/09 10:43:24 UTC

[PR] 1936 fix tcp tls server [iggy]

mayakerostasia opened a new pull request, #1983:
URL: https://github.com/apache/iggy/pull/1983

   ## Description
   TCP-TLS server using compio & uring_tpc
   
   ### Why
   Switch to compio broke prior TLS server implementation
   
   ### How
   Remove `todo!`s and ensure source compiles.  Some slight modifications to imports necessary to keep types consistent across TLS listener/sender/server files.
   
   
   ## General Coding Remarks
   
   - **Code Formatting**: Good
   - **Code Linting**: Lot's of problems unrelated to these changes
   - **Unit Testing**: Unchecked
   - **Integration Testing**: Unchecked
   - **Project Structure**: Unchecked
   - **Build Integrity**: Has some problems while running, unsure if it has to do with changes
   - **Check unused dependencies**: Done - left "Ctrlc"
   - **Sort dependencies**: Done for /server


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] 1936 fix tcp tls server [iggy]

Posted by "mayakerostasia (via GitHub)" <gi...@apache.org>.
mayakerostasia commented on PR #1983:
URL: https://github.com/apache/iggy/pull/1983#issuecomment-3074999489

   ## Test Results
   ### One
   ```rust
   running 2 tests
   test server::specific::tcp_tls_scenario_should_be_valid has been running for over 60 seconds
   test server::specific::tcp_tls_self_signed_scenario_should_be_valid has been running for over 60 seconds
   test server::specific::tcp_tls_self_signed_scenario_should_be_valid ... FAILED
   test server::specific::tcp_tls_scenario_should_be_valid ... FAILED
   
   failures:
   
   ---- server::specific::tcp_tls_self_signed_scenario_should_be_valid stdout ----
   
   thread 'server::specific::tcp_tls_self_signed_scenario_should_be_valid' panicked at core/integration/src/test_server.rs:350:13:
   Failed to load config from file local_data_206667835506426658079756885994169604097/runtime/current_config.toml in 60 s!
   Iggy server stdout:
     ___                             ____
   ```
   
   ### Two
   ```rust
   thread 'server::specific::tcp_tls_scenario_should_be_valid' panicked at core/integration/src/test_server.rs:350:13:
   Failed to load config from file local_data_131600921475352707465903685000481380353/runtime/current_config.toml in 60 s!
   note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
   ```
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] 1936 fix tcp tls server [iggy]

Posted by "mayakerostasia (via GitHub)" <gi...@apache.org>.
mayakerostasia closed pull request #1983: 1936 fix tcp tls server
URL: https://github.com/apache/iggy/pull/1983


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] 1936 fix tcp tls server [iggy]

Posted by "mayakerostasia (via GitHub)" <gi...@apache.org>.
mayakerostasia commented on PR #1983:
URL: https://github.com/apache/iggy/pull/1983#issuecomment-3224092671

   #2130 Seems to fix the issue with TLS scenarios


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org