You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@streampark.apache.org by "tisonkun (via GitHub)" <gi...@apache.org> on 2023/03/24 17:33:39 UTC

[GitHub] [incubator-streampark] tisonkun opened a new pull request, #2507: [Improve] Consistently use pnpm in build and CI

tisonkun opened a new pull request, #2507:
URL: https://github.com/apache/incubator-streampark/pull/2507

   ## What changes were proposed in this pull request
   
   Currently, Maven build use npm for installing deps which is slow and unstable - let's consistently use pnpm in build and CI.
   
   ## Brief change log
   
   1. Update build and CI settings.
   2. Update webapp README docs.
   
   ## Verifying this change
   
   CI should pass.
   
   ## Does this pull request potentially affect one of the following parts
    - Dependencies (does it add or upgrade a dependency): (no)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-streampark] wolfboys merged pull request #2507: [Improve] Consistently use pnpm in build and CI

Posted by "wolfboys (via GitHub)" <gi...@apache.org>.
wolfboys merged PR #2507:
URL: https://github.com/apache/incubator-streampark/pull/2507


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-streampark] wolfboys commented on pull request #2507: [Improve] Consistently use pnpm in build and CI

Posted by "wolfboys (via GitHub)" <gi...@apache.org>.
wolfboys commented on PR #2507:
URL: https://github.com/apache/incubator-streampark/pull/2507#issuecomment-1483658685

   Thanks for your contribution, my local test failed 😫.  
   <img width="1053" alt="image" src="https://user-images.githubusercontent.com/13284744/227675554-b180a11f-dd6a-4ece-9e5f-2ae28001a4fa.png">
   
   
   so I upgraded version of frontend-maven-plugin to 1.12.1, and it succeeded:
   
   ```...
   <groupId>com.github.eirslett</groupId>
   <artifactId>frontend-maven-plugin</artifactId>
   <version>1.12.1</version>
   ...
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-streampark] tisonkun commented on pull request #2507: [Improve] Consistently use pnpm in build and CI

Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun commented on PR #2507:
URL: https://github.com/apache/incubator-streampark/pull/2507#issuecomment-1483703201

   @wolfboys Upgraded. Let's wait a bit for INFRA approval.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-streampark] tisonkun commented on pull request #2507: [Improve] Consistently use pnpm in build and CI

Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun commented on PR #2507:
URL: https://github.com/apache/incubator-streampark/pull/2507#issuecomment-1483900872

   Workaround by using corepack.
   
   Ready for review cc @wolfboys @wangsizhu0504 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org