You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Deepak Garg <de...@citrix.com> on 2012/09/04 04:36:31 UTC
RE: Review Request: CS-16168 [AutoScale] : Deletion of Account
doesn't delete the AutoScale LB rule
Can someone please review https://reviews.apache.org/r/6825/ ?
Thanks
Deepak
-----Original Message-----
From: Deepak Garg [mailto:noreply@reviews.apache.org] On Behalf Of Deepak Garg
Sent: Wednesday, August 29, 2012 1:32 PM
To: Vijay Venkatachalam; Pranav Saxena
Cc: cloudstack; Deepak Garg
Subject: Review Request: CS-16168 [AutoScale] : Deletion of Account doesn't delete the AutoScale LB rule
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6825/
-----------------------------------------------------------
Review request for cloudstack, Pranav Saxena and Vijay Venkatachalam.
Description
-------
CS-16168
[AutoScale] : Deletion of Account doesn't delete the AutoScale LB rule
Steps
==============
1. Create a Domain inside the ROOT domain, and then create a user for that domain.
2. Login to CS as that user and create an Autoscale LB rule.
3. Let the LB rule get created and the minimum number of VM deployed. Now Delete the Account.
Observation
==============
1. The LB rule Doesn't get deleted (The attached VM gets deleted but the AutoScale LB rule stays)
This addresses bug CS-16168.
Diffs
-----
server/src/com/cloud/network/as/AutoScaleManager.java 7ea7807
server/src/com/cloud/network/as/AutoScaleManagerImpl.java 8c39097
server/src/com/cloud/network/as/dao/AutoScalePolicyDao.java 8edfa94
server/src/com/cloud/network/as/dao/AutoScalePolicyDaoImpl.java 5dfe080
server/src/com/cloud/network/as/dao/AutoScaleVmProfileDao.java 0803571
server/src/com/cloud/network/as/dao/AutoScaleVmProfileDaoImpl.java 12392c3
server/src/com/cloud/network/as/dao/ConditionDao.java bb0f77f
server/src/com/cloud/network/as/dao/ConditionDaoImpl.java 338fe19
server/src/com/cloud/network/lb/LoadBalancingRulesManagerImpl.java 8671151
server/src/com/cloud/user/AccountManagerImpl.java 0a11dc4
Diff: https://reviews.apache.org/r/6825/diff/
Testing
-------
Manually tested on my setup.
Thanks,
Deepak Garg
RE: Review Request: CS-16168 [AutoScale] : Deletion of Account
doesn't delete the AutoScale LB rule
Posted by Vijay Venkatachalam <Vi...@citrix.com>.
The bug is in re-opened state, you might want to check again and root cause that before this can be shipped.
Otherwise, the changes looks fine.
- Vijay V.
> -----Original Message-----
> From: Deepak Garg
> Sent: Tuesday, September 04, 2012 8:07 AM
> To: cloudstack-dev@incubator.apache.org
> Cc: Pranav Saxena; Vijay Venkatachalam
> Subject: RE: Review Request: CS-16168 [AutoScale] : Deletion of Account
> doesn't delete the AutoScale LB rule
>
> Can someone please review https://reviews.apache.org/r/6825/ ?
>
>
> Thanks
> Deepak
>
>
> -----Original Message-----
> From: Deepak Garg [mailto:noreply@reviews.apache.org] On Behalf Of
> Deepak Garg
> Sent: Wednesday, August 29, 2012 1:32 PM
> To: Vijay Venkatachalam; Pranav Saxena
> Cc: cloudstack; Deepak Garg
> Subject: Review Request: CS-16168 [AutoScale] : Deletion of Account doesn't
> delete the AutoScale LB rule
>
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6825/
> -----------------------------------------------------------
>
> Review request for cloudstack, Pranav Saxena and Vijay Venkatachalam.
>
>
> Description
> -------
>
> CS-16168
> [AutoScale] : Deletion of Account doesn't delete the AutoScale LB rule Steps
> ============== 1. Create a Domain inside the ROOT domain, and then
> create a user for that domain.
> 2. Login to CS as that user and create an Autoscale LB rule.
> 3. Let the LB rule get created and the minimum number of VM deployed.
> Now Delete the Account.
>
> Observation
> ==============
> 1. The LB rule Doesn't get deleted (The attached VM gets deleted but the
> AutoScale LB rule stays)
>
>
> This addresses bug CS-16168.
>
>
> Diffs
> -----
>
> server/src/com/cloud/network/as/AutoScaleManager.java 7ea7807
> server/src/com/cloud/network/as/AutoScaleManagerImpl.java 8c39097
> server/src/com/cloud/network/as/dao/AutoScalePolicyDao.java 8edfa94
> server/src/com/cloud/network/as/dao/AutoScalePolicyDaoImpl.java
> 5dfe080
> server/src/com/cloud/network/as/dao/AutoScaleVmProfileDao.java
> 0803571
> server/src/com/cloud/network/as/dao/AutoScaleVmProfileDaoImpl.java
> 12392c3
> server/src/com/cloud/network/as/dao/ConditionDao.java bb0f77f
> server/src/com/cloud/network/as/dao/ConditionDaoImpl.java 338fe19
> server/src/com/cloud/network/lb/LoadBalancingRulesManagerImpl.java
> 8671151
> server/src/com/cloud/user/AccountManagerImpl.java 0a11dc4
>
> Diff: https://reviews.apache.org/r/6825/diff/
>
>
> Testing
> -------
>
> Manually tested on my setup.
>
>
> Thanks,
>
> Deepak Garg