You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by datumbox <gi...@git.apache.org> on 2017/03/01 00:04:45 UTC

[GitHub] spark issue #17059: [SPARK-19733][ML]Removed unnecessary castings and refact...

Github user datumbox commented on the issue:

    https://github.com/apache/spark/pull/17059
  
    I updated the exception message and I added Unit-tests to cover the checkedCast method as @imatiach-msft suggested. I have not corrected the value of regParam but I had a look and it is safe to do so. 
    
    Thanks everyone for their comments and recommendations. Please consider merging this PR with master because many people are working lately on the ALS and soon conflicts will arise.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org