You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@quickstep.apache.org by craig-chasseur <gi...@git.apache.org> on 2016/06/14 07:55:03 UTC

[GitHub] incubator-quickstep pull request #30: Fix conditional per-target flags for l...

GitHub user craig-chasseur opened a pull request:

    https://github.com/apache/incubator-quickstep/pull/30

    Fix conditional per-target flags for lexer

    set_target_properties() overwrites per-target COMPILE_FLAGS rather than replacing them. Also, compiler flags should be checked before enabling them.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/craig-chasseur/incubator-quickstep lexer-flags-fix

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-quickstep/pull/30.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #30
    
----
commit 29768a7297746606089c6b2ebca1a9bf44180614
Author: Craig Chasseur <sp...@gmail.com>
Date:   2016-06-14T07:51:52Z

    Fix conditional per-target flags for lexer

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-quickstep issue #30: Fix conditional per-target flags for lexer

Posted by pateljm <gi...@git.apache.org>.
Github user pateljm commented on the issue:

    https://github.com/apache/incubator-quickstep/pull/30
  
    Merged.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-quickstep pull request #30: Fix conditional per-target flags for l...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-quickstep/pull/30


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---