You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Abhishek Kumar <la...@gmail.com> on 2017/01/23 11:46:17 UTC
Review Request 55839: Hive View 2.0: Code hints for query editor are
not working
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55839/
-----------------------------------------------------------
Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, Pallav Kulshreshtha, and Rohit Choudhary.
Bugs: AMBARI-19673
https://issues.apache.org/jira/browse/AMBARI-19673
Repository: ambari
Description
-------
User should be able to see code hints and syntax colorization while typing hive queries.
Diffs
-----
contrib/views/hive20/src/main/resources/ui/app/components/query-editor.js 27d43d5
contrib/views/hive20/src/main/resources/ui/ember-cli-build.js e41c8e8
Diff: https://reviews.apache.org/r/55839/diff/
Testing
-------
Manually tested
Thanks,
Abhishek Kumar
Re: Review Request 55839: Hive View 2.0: Code hints for query editor
are not working
Posted by Nitiraj Rathore <ni...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55839/#review162778
-----------------------------------------------------------
Fix it, then Ship it!
Ship It!
contrib/views/hive20/src/main/resources/ui/app/components/query-editor.js (line 79)
<https://reviews.apache.org/r/55839/#comment234127>
is this commented method required? If not please remove.
- Nitiraj Rathore
On Jan. 23, 2017, 11:46 a.m., Abhishek Kumar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55839/
> -----------------------------------------------------------
>
> (Updated Jan. 23, 2017, 11:46 a.m.)
>
>
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, Pallav Kulshreshtha, and Rohit Choudhary.
>
>
> Bugs: AMBARI-19673
> https://issues.apache.org/jira/browse/AMBARI-19673
>
>
> Repository: ambari
>
>
> Description
> -------
>
> User should be able to see code hints and syntax colorization while typing hive queries.
>
>
> Diffs
> -----
>
> contrib/views/hive20/src/main/resources/ui/app/components/query-editor.js 27d43d5
> contrib/views/hive20/src/main/resources/ui/ember-cli-build.js e41c8e8
>
> Diff: https://reviews.apache.org/r/55839/diff/
>
>
> Testing
> -------
>
> Manually tested
>
>
> Thanks,
>
> Abhishek Kumar
>
>