You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2021/06/02 04:55:07 UTC
[GitHub] [ozone] sky76093016 opened a new pull request #2296: HDDS-5285. Document block deleting service classes
sky76093016 opened a new pull request #2296:
URL: https://github.com/apache/ozone/pull/2296
## What changes were proposed in this pull request?
Add class-level javadoc for DeletedBlockLogStateManager and DeletedBlockLogStateManagerImpl.
## What is the link to the Apache JIRA
https://issues.apache.org/jira/projects/HDDS/issues/HDDS-5285
## How was this patch tested?
No test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] cku328 merged pull request #2296: HDDS-5285. Document block deleting service classes
Posted by GitBox <gi...@apache.org>.
cku328 merged pull request #2296:
URL: https://github.com/apache/ozone/pull/2296
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] sky76093016 commented on a change in pull request #2296: HDDS-5285. Document block deleting service classes
Posted by GitBox <gi...@apache.org>.
sky76093016 commented on a change in pull request #2296:
URL: https://github.com/apache/ozone/pull/2296#discussion_r646468871
##########
File path: hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/block/DeletedBlockLogStateManager.java
##########
@@ -27,7 +27,8 @@
import java.util.ArrayList;
/**
- * TODO: javadoc.
+ * DeletedBlockLogStateManager interface to provide BlocksTransaction
Review comment:
This seems to be a good proposal, let me revise it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] cku328 commented on pull request #2296: HDDS-5285. Document block deleting service classes
Posted by GitBox <gi...@apache.org>.
cku328 commented on pull request #2296:
URL: https://github.com/apache/ozone/pull/2296#issuecomment-857857873
PR merged.
Thanks @sky76093016 for the contribution and @jojochuang for the review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] jojochuang commented on a change in pull request #2296: HDDS-5285. Document block deleting service classes
Posted by GitBox <gi...@apache.org>.
jojochuang commented on a change in pull request #2296:
URL: https://github.com/apache/ozone/pull/2296#discussion_r646460588
##########
File path: hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/block/DeletedBlockLogStateManager.java
##########
@@ -27,7 +27,8 @@
import java.util.ArrayList;
/**
- * TODO: javadoc.
+ * DeletedBlockLogStateManager interface to provide BlocksTransaction
Review comment:
I think we can make this more verbose.
if you trace the code, you'll find it ultimately writes to SCMMetadataStore.getDeletedBlocksTXTable() which says "A Table that keeps the deleted blocks lists and transactions."
You might say it's an interface to manage deleted blocks and record them in the underlying persist store.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org